[feat](nereids) cost of column-prunning project is 0#35147
Closed
englefly wants to merge 1 commit intoapache:masterfrom
Closed
[feat](nereids) cost of column-prunning project is 0#35147englefly wants to merge 1 commit intoapache:masterfrom
englefly wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42149 ms |
morrySnow
approved these changes
May 21, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
May 21, 2024
| @Override | ||
| public Cost visitPhysicalProject(PhysicalProject<? extends Plan> physicalProject, PlanContext context) { | ||
| return CostV1.ofCpu(context.getSessionVariable(), 1); | ||
| long exprCount = physicalProject.getProjects().stream().filter(proj -> !(proj instanceof Slot)).count(); |
Contributor
There was a problem hiding this comment.
should check output.size() is same with child's output.size().
otherwise, we may lose some column prune project when select best cost plan
TPC-DS: Total hot run time: 181653 ms |
ClickBench: Total hot run time: 30.67 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
it helps to choose mv if mv saves some expression effort.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...