[Feature](topn) support general expr with topn filter and some refactor #35405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update update update update update update update
This reverts commit 6c0992b.
update update update update update update update
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return cast_to_string<type, ValueType>(v.get_value(), v.get_scale()); | ||
| } | ||
|
|
||
| bool RuntimePredicate::_init(PrimitiveType type) { |
Contributor
There was a problem hiding this comment.
warning: function '_init' exceeds recommended size/complexity thresholds [readability-function-size]
bool RuntimePredicate::_init(PrimitiveType type) {
^Additional context
be/src/runtime/runtime_predicate.cpp:111: 82 lines including whitespace and comments (threshold 80)
bool RuntimePredicate::_init(PrimitiveType type) {
^|
|
||
| #pragma once | ||
|
|
||
| #include <gen_cpp/types.pb.h> |
Contributor
There was a problem hiding this comment.
warning: 'gen_cpp/types.pb.h' file not found [clang-diagnostic-error]
#include <gen_cpp/types.pb.h>
^
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41148 ms |
TPC-DS: Total hot run time: 172205 ms |
ClickBench: Total hot run time: 30.98 s |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41476 ms |
TPC-DS: Total hot run time: 172201 ms |
ClickBench: Total hot run time: 30.56 s |
BiteTheDDDDt
changed the title
englefly
approved these changes
May 27, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
May 27, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 27, 2024
…or (#35405) support general expr with topn filter and some refactor Co-authored-by: minghong <englefly@gmail.com>
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
May 27, 2024
…or (apache#35405) support general expr with topn filter and some refactor Co-authored-by: minghong <englefly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
merge from #35064 and #34914
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...