[pipeline](tracing) Fix pipeline tracing tools #35595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // belongs to exec_env, for all query, if enabled | ||
| class PipelineTracerContext { | ||
| public: | ||
| PipelineTracerContext() : _data(std::make_shared<QueryTracesMap>()) {} |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
Suggested change
| PipelineTracerContext() : _data(std::make_shared<QueryTracesMap>()) {} | |
| PipelineTracerContext() : _data(std::make_shared<QueryTracesMap>()) = default; |
zclllyybb
reviewed
May 29, 2024
| def to_json(self) : | ||
| json = {"name": self.task_name, "cat": self.state_name, "ph": "X", "ts": self.start_time, "dur": self.end_time - self.start_time, | ||
| json = {"name": self.task_name, "ph": "X", "ts": self.start_time, "dur": self.end_time - self.start_time, | ||
| "pid": self.get_core(), "tid": self.thread_id} |
Contributor
There was a problem hiding this comment.
add "args": {"tags": self.query_id} to find same query
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41147 ms |
TPC-DS: Total hot run time: 168823 ms |
ClickBench: Total hot run time: 30.44 s |
yiguolei
approved these changes
May 29, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zclllyybb
requested changes
May 29, 2024
| } | ||
|
|
||
| void PipelineTracerContext::_update(std::function<void(QueryTracesMap&)>&& handler) { | ||
| auto map_ptr = std::atomic_load_explicit(&_data, std::memory_order_relaxed); |
Contributor
There was a problem hiding this comment.
do not use these atomic APIs for std::shared_ptr. they are deprecated in C++20 and will be removed in C++26. use std::atomic<shared_ptr> instead.
|
|
||
| ScheduleRecord record; | ||
| while (_datas[query_id].try_dequeue(record)) { | ||
| while ((*map_ptr)[QueryID {query_id}]->try_dequeue(record)) { |
Contributor
There was a problem hiding this comment.
maybe here we should add some comment to let people know it's thread-safe by copy-and-swap for any possible modification.
zclllyybb
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx