[fix](s3) move s3 providers to fe-common to be accessible for jni reader#35779
Merged
yiguolei merged 1 commit intoapache:branch-2.1from Jun 3, 2024
Merged
[fix](s3) move s3 providers to fe-common to be accessible for jni reader#35779yiguolei merged 1 commit intoapache:branch-2.1from
yiguolei merged 1 commit intoapache:branch-2.1from
Conversation
…der (apache#35690) `PropertyConverter.setS3FsAccess` has add customized s3 providers: ``` public static final List<String> AWS_CREDENTIALS_PROVIDERS = Arrays.asList( DataLakeAWSCredentialsProvider.class.getName(), TemporaryAWSCredentialsProvider.class.getName(), SimpleAWSCredentialsProvider.class.getName(), EnvironmentVariableCredentialsProvider.class.getName(), IAMInstanceCredentialsProvider.class.getName()); ``` And these providers are set as configuration value of `fs.s3a.aws.credentials.provider`, which will be used as configuration to build s3 reader in JNI readers. However, `DataLakeAWSCredentialsProvider` is in `fe-core`, that is not dependent by JNI readers, so we have to move s3 providers to `fe-common'.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport: #35690
PropertyConverter.setS3FsAccesshas add customized s3 providers:And these providers are set as configuration value of
fs.s3a.aws.credentials.provider, which will be used as configuration to build s3 reader in JNI readers. However,DataLakeAWSCredentialsProvideris infe-core, that is not dependent by JNI readers, so we have to move s3 providers to `fe-common'.