[refactor](pipeline) Delete non-pipeline exec nodes#35803
[refactor](pipeline) Delete non-pipeline exec nodes#35803Gabriel39 merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| template <typename ParentType> | ||
| Status ParallelScannerBuilder<ParentType>::_build_scanners_by_rowid( | ||
| std::list<VScannerSPtr>& scanners) { | ||
| Status ParallelScannerBuilder::_build_scanners_by_rowid(std::list<VScannerSPtr>& scanners) { |
There was a problem hiding this comment.
warning: function '_build_scanners_by_rowid' exceeds recommended size/complexity thresholds [readability-function-size]
Status ParallelScannerBuilder::_build_scanners_by_rowid(std::list<VScannerSPtr>& scanners) {
^Additional context
be/src/olap/parallel_scanner_builder.cpp:40: 126 lines including whitespace and comments (threshold 80)
Status ParallelScannerBuilder::_build_scanners_by_rowid(std::list<VScannerSPtr>& scanners) {
^| struct BlockRowPos { | ||
| BlockRowPos() : block_num(0), row_num(0), pos(0) {} | ||
| int64_t block_num; //the pos at which block | ||
| int64_t row_num; //the pos at which row |
There was a problem hiding this comment.
warning: use default member initializer for 'row_num' [modernize-use-default-member-init]
be/src/pipeline/dependency.h:508:
- BlockRowPos() : block_num(0), row_num(0), pos(0) {}
+ BlockRowPos() : block_num(0), , pos(0) {}| int64_t row_num; //the pos at which row | |
| int64_t row_num{0}; //the pos at which row |
| BlockRowPos() : block_num(0), row_num(0), pos(0) {} | ||
| int64_t block_num; //the pos at which block | ||
| int64_t row_num; //the pos at which row | ||
| int64_t pos; //pos = all blocks size + row_num |
There was a problem hiding this comment.
warning: use default member initializer for 'pos' [modernize-use-default-member-init]
be/src/pipeline/dependency.h:508:
- BlockRowPos() : block_num(0), row_num(0), pos(0) {}
+ BlockRowPos() : block_num(0), row_num(0), {}| int64_t pos; //pos = all blocks size + row_num | |
| int64_t pos{0}; //pos = all blocks size + row_num |
| Status ScanLocalState<Derived>::_normalize_in_and_eq_predicate( | ||
| vectorized::VExpr* expr, vectorized::VExprContext* expr_ctx, SlotDescriptor* slot, | ||
| ColumnValueRange<T>& range, vectorized::VScanNode::PushDownType* pdt) { | ||
| Status ScanLocalState<Derived>::_normalize_in_and_eq_predicate(vectorized::VExpr* expr, |
There was a problem hiding this comment.
warning: function '_normalize_in_and_eq_predicate' has cognitive complexity of 63 (threshold 50) [readability-function-cognitive-complexity]
Status ScanLocalState<Derived>::_normalize_in_and_eq_predicate(vectorized::VExpr* expr,
^Additional context
be/src/pipeline/exec/scan_operator.cpp:593: +1, including nesting penalty of 0, nesting level increased to 1
if (TExprNodeType::IN_PRED == expr->node_type()) {
^be/src/pipeline/exec/scan_operator.cpp:597: +2, including nesting penalty of 1, nesting level increased to 2
if (hybrid_set != nullptr) {
^be/src/pipeline/exec/scan_operator.cpp:599: +3, including nesting penalty of 2, nesting level increased to 3
if (hybrid_set->size() <=
^be/src/pipeline/exec/scan_operator.cpp:602: +1, nesting level increased to 3
} else {
^be/src/pipeline/exec/scan_operator.cpp:607: +1, nesting level increased to 2
} else {
^be/src/pipeline/exec/scan_operator.cpp:611: +3, including nesting penalty of 2, nesting level increased to 3
if (temp_pdt == PushDownType::UNACCEPTABLE) {
^be/src/pipeline/exec/scan_operator.cpp:621: +3, including nesting penalty of 2, nesting level increased to 3
if (!state->use_set) {
^be/src/pipeline/exec/scan_operator.cpp:628: +2, including nesting penalty of 1, nesting level increased to 2
while (iter->has_next()) {
^be/src/pipeline/exec/scan_operator.cpp:631: +3, including nesting penalty of 2, nesting level increased to 3
if (nullptr == iter->get_value()) {
^be/src/pipeline/exec/scan_operator.cpp:636: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:636: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:642: +1, nesting level increased to 1
} else if (TExprNodeType::BINARY_PRED == expr->node_type()) {
^be/src/pipeline/exec/scan_operator.cpp:644: nesting level increased to 2
auto eq_checker = [](const std::string& fn_name) { return fn_name == "eq"; };
^be/src/pipeline/exec/scan_operator.cpp:650: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:650: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:653: +2, including nesting penalty of 1, nesting level increased to 2
if (temp_pdt == PushDownType::UNACCEPTABLE) {
^be/src/pipeline/exec/scan_operator.cpp:659: +2, including nesting penalty of 1, nesting level increased to 2
if (value.data != nullptr) {
^be/src/pipeline/exec/scan_operator.cpp:660: +3, including nesting penalty of 2, nesting level increased to 3
if constexpr (T == TYPE_CHAR || T == TYPE_VARCHAR || T == TYPE_STRING ||
^be/src/pipeline/exec/scan_operator.cpp:660: +1
if constexpr (T == TYPE_CHAR || T == TYPE_VARCHAR || T == TYPE_STRING ||
^be/src/pipeline/exec/scan_operator.cpp:663: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:663: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:666: +1, nesting level increased to 3
} else {
^be/src/pipeline/exec/scan_operator.cpp:667: +4, including nesting penalty of 3, nesting level increased to 4
if (sizeof(typename PrimitiveTypeTraits<T>::CppType) != value.size) {
^be/src/pipeline/exec/scan_operator.cpp:672: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:672: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_change_value_range<true>(
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^| template <bool with_other_conjuncts> | ||
| Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts( | ||
| Block* output_block, size_t hash_table_bucket_size) { | ||
| Status ProcessHashTableProbe<JoinOpType>::do_mark_join_conjuncts(Block* output_block, |
There was a problem hiding this comment.
warning: function 'do_mark_join_conjuncts' has cognitive complexity of 56 (threshold 50) [readability-function-cognitive-complexity]
_conjuncts>
^Additional context
be/src/vec/exec/join/process_hash_table_probe_impl.h:376: +1, including nesting penalty of 0, nesting level increased to 1
ck->rows();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:385: +1, including nesting penalty of 0, nesting level increased to 1
et_data();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:397: +2, including nesting penalty of 1, nesting level increased to 2
tched = -1;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:399: +3, including nesting penalty of 2, nesting level increased to 3
ucket_size;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:400: +4, including nesting penalty of 3, nesting level increased to 4
are_join) {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:403: +1, nesting level increased to 4
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:403: +5, including nesting penalty of 4, nesting level increased to 5
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:406: +1, nesting level increased to 5
i] = false;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:409: +1, nesting level increased to 5
_indexs[i];
^be/src/vec/exec/join/process_hash_table_probe_impl.h:415: +2, including nesting penalty of 1, nesting level increased to 2
}
^be/src/vec/exec/join/process_hash_table_probe_impl.h:419: +1, nesting level increased to 1
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:419: +2, including nesting penalty of 1, nesting level increased to 2
} else {
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:419: +3, including nesting penalty of 2, nesting level increased to 3
} else {
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:426: +1, including nesting penalty of 0, nesting level increased to 1
er.data();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:430: +2, including nesting penalty of 1, nesting level increased to 2
ll = false;
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:430: +3, including nesting penalty of 2, nesting level increased to 3
ll = false;
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:436: +2, including nesting penalty of 1, nesting level increased to 2
ter.data();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:455: +1
_has_null =
^be/src/vec/exec/join/process_hash_table_probe_impl.h:456: +1, including nesting penalty of 0, nesting level increased to 1
_conjuncts;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:458: +2, including nesting penalty of 1, nesting level increased to 2
_indexs[i];
^be/src/vec/exec/join/process_hash_table_probe_impl.h:460: +3, including nesting penalty of 2, nesting level increased to 3
_indexs[i];
^be/src/vec/exec/join/process_hash_table_probe_impl.h:462: +1
[i] = true;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:466: +1, nesting level increased to 2
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:466: +3, including nesting penalty of 2, nesting level increased to 3
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:469: +1, nesting level increased to 3
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:469: +4, including nesting penalty of 3, nesting level increased to 4
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:469: +1
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:477: +1, including nesting penalty of 0, nesting level increased to 1
}
^be/src/vec/exec/join/process_hash_table_probe_impl.h:479: +2, including nesting penalty of 1, nesting level increased to 2
mark column
^| template <bool with_other_conjuncts> | ||
| Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts( | ||
| Block* output_block, size_t hash_table_bucket_size) { | ||
| Status ProcessHashTableProbe<JoinOpType>::do_mark_join_conjuncts(Block* output_block, |
There was a problem hiding this comment.
warning: function 'do_mark_join_conjuncts' exceeds recommended size/complexity thresholds [readability-function-size]
_conjuncts>
^Additional context
be/src/vec/exec/join/process_hash_table_probe_impl.h:363: 123 lines including whitespace and comments (threshold 80)
_conjuncts>
^| Status ProcessHashTableProbe<JoinOpType, Parent>::do_other_join_conjuncts( | ||
| Block* output_block, std::vector<uint8_t>& visited, bool has_null_in_build_side) { | ||
| template <int JoinOpType> | ||
| Status ProcessHashTableProbe<JoinOpType>::do_other_join_conjuncts(Block* output_block, |
There was a problem hiding this comment.
warning: function 'do_other_join_conjuncts' has cognitive complexity of 61 (threshold 50) [readability-function-cognitive-complexity]
JoinOpType>
^Additional context
be/src/vec/exec/join/process_hash_table_probe_impl.h:495: +1, including nesting penalty of 0, nesting level increased to 1
ck->rows();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:504: +1, including nesting penalty of 0, nesting level increased to 1
ll = false;
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:504: +2, including nesting penalty of 1, nesting level increased to 2
ll = false;
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:519: +1, including nesting penalty of 0, nesting level increased to 1
.data();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:526: +2, including nesting penalty of 1, nesting level increased to 2
re are any.
^be/src/vec/exec/join/process_hash_table_probe_impl.h:530: +3, including nesting penalty of 2, nesting level increased to 3
mn_ptr[i];
^be/src/vec/exec/join/process_hash_table_probe_impl.h:533: +1, nesting level increased to 3
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:535: +3, including nesting penalty of 2, nesting level increased to 3
}
^be/src/vec/exec/join/process_hash_table_probe_impl.h:540: +2, including nesting penalty of 1, nesting level increased to 2
^be/src/vec/exec/join/process_hash_table_probe_impl.h:541: +3, including nesting penalty of 2, nesting level increased to 3
unt; ++i) {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:544: +4, including nesting penalty of 3, nesting level increased to 4
mn_ptr[i]);
^be/src/vec/exec/join/process_hash_table_probe_impl.h:550: +1, nesting level increased to 1
er_column);
^be/src/vec/exec/join/process_hash_table_probe_impl.h:556: +2, including nesting penalty of 1, nesting level increased to 2
().data();
^be/src/vec/exec/join/process_hash_table_probe_impl.h:559: +3, including nesting penalty of 2, nesting level increased to 3
indexs[i];
^be/src/vec/exec/join/process_hash_table_probe_impl.h:560: +4, including nesting penalty of 3, nesting level increased to 4
EMI_JOIN) {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:562: +1, nesting level increased to 4
i] = false;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:566: +1, nesting level increased to 4
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:569: +1, nesting level increased to 3
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:569: +4, including nesting penalty of 3, nesting level increased to 4
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:572: +1, nesting level increased to 4
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:573: +5, including nesting penalty of 4, nesting level increased to 5
i] = false;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:581: +1, nesting level increased to 1
er_column);
^be/src/vec/exec/join/process_hash_table_probe_impl.h:583: +2, including nesting penalty of 1, nesting level increased to 2
NTI_JOIN) {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:586: +1, nesting level increased to 1
;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:588: +2, including nesting penalty of 1, nesting level increased to 2
r_size = 0;
^be/src/vec/exec/join/process_hash_table_probe_impl.h:595: +1, including nesting penalty of 0, nesting level increased to 1
0);
^be/src/vec/exec/join/process_hash_table_probe_impl.h:599: +1, nesting level increased to 1
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:599: +2, including nesting penalty of 1, nesting level increased to 2
} else {
^be/src/vec/exec/join/process_hash_table_probe_impl.h:604: +2, including nesting penalty of 1, nesting level increased to 2
;
^be/src/common/status.h:614: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/exec/join/process_hash_table_probe_impl.h:604: +3, including nesting penalty of 2, nesting level increased to 3
;
^be/src/common/status.h:616: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^| Status ProcessHashTableProbe<JoinOpType, Parent>::do_other_join_conjuncts( | ||
| Block* output_block, std::vector<uint8_t>& visited, bool has_null_in_build_side) { | ||
| template <int JoinOpType> | ||
| Status ProcessHashTableProbe<JoinOpType>::do_other_join_conjuncts(Block* output_block, |
There was a problem hiding this comment.
warning: function 'do_other_join_conjuncts' exceeds recommended size/complexity thresholds [readability-function-size]
JoinOpType>
^Additional context
be/src/vec/exec/join/process_hash_table_probe_impl.h:490: 116 lines including whitespace and comments (threshold 80)
JoinOpType>
^| pipeline::OlapScanLocalState* local_state = (pipeline::OlapScanLocalState*)_local_state; | ||
| INCR_COUNTER(local_state); | ||
| } | ||
| pipeline::OlapScanLocalState* local_state = (pipeline::OlapScanLocalState*)_local_state; |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| pipeline::OlapScanLocalState* local_state = (pipeline::OlapScanLocalState*)_local_state; | |
| auto* local_state = (pipeline::OlapScanLocalState*)_local_state; |
TPC-H: Total hot run time: 40236 ms |
TPC-DS: Total hot run time: 172575 ms |
ClickBench: Total hot run time: 30.73 s |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40396 ms |
TPC-DS: Total hot run time: 170587 ms |
ClickBench: Total hot run time: 31.02 s |
|
TeamCity be ut coverage result: |
6 participants
Proposed changes
Issue Number: close #xxx