-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](cloud txn insert) Add more ut; Remove duplicated table_id to reduce fdb value length #36135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| } | ||
| } | ||
|
|
||
| TEST(MetaServiceTest, CommitTxnWithSubTxnTest2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, CommitTxnWithSubTxnTest2) {
^Additional context
cloud/test/meta_service_test.cpp:1593: 176 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, CommitTxnWithSubTxnTest2) {
^
TPC-H: Total hot run time: 40345 ms |
TPC-DS: Total hot run time: 173474 ms |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 31.11 s |
…o reduce fdb value length
|
run cloud_ut |
|
run fe_ut |
|
run feut cloudut |
|
run cloudut |
|
run buildall |
TPC-H: Total hot run time: 40102 ms |
TPC-DS: Total hot run time: 169192 ms |
ClickBench: Total hot run time: 30.18 s |
|
run cloudut |
|
run cloudp1 |
|
run cloud_p1 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…o reduce fdb value length (#36135) ## Proposed changes 1. add more meta_service ut; 2. remove duplicated table_id to reduce fdb value length
Proposed changes