Skip to content

[minor] better column name error description #36154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jun 12, 2024
Merged

[minor] better column name error description #36154

morningman merged 1 commit into from
Jun 12, 2024

Conversation

@xiedeyantu
Copy link
Member

@xiedeyantu xiedeyantu commented Jun 12, 2024

Proposed changes

If column name is count(*), it can only throw 'No field name set', it not friendly to us.

@doris-robot
Copy link

doris-robot commented Jun 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xiedeyantu xiedeyantu changed the title better column name error description [minor]better column name error description Jun 12, 2024
@xiedeyantu xiedeyantu changed the title [minor]better column name error description [minor] better column name error description Jun 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@xiedeyantu
Copy link
Member Author

xiedeyantu commented Jun 12, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 12, 2024

TeamCity be ut coverage result:
Function Coverage: 36.40% (8984/24681)
Line Coverage: 27.95% (73463/262867)
Region Coverage: 27.38% (38090/139096)
Branch Coverage: 24.01% (19345/80576)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e30cabec71b96aea093940dc94cfba2214aa66c2_e30cabec71b96aea093940dc94cfba2214aa66c2/report/index.html

@doris-robot
Copy link

doris-robot commented Jun 12, 2024

TPC-H: Total hot run time: 40199 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e30cabec71b96aea093940dc94cfba2214aa66c2, data reload: false

------ Round 1 ----------------------------------
q1	17655	4312	4230	4230
q2	2017	188	195	188
q3	10441	1193	1109	1109
q4	10189	855	777	777
q5	7473	2642	2583	2583
q6	221	140	135	135
q7	934	633	588	588
q8	9217	2052	2016	2016
q9	8835	6430	6440	6430
q10	8923	3751	3738	3738
q11	445	236	234	234
q12	421	238	221	221
q13	17814	2930	2969	2930
q14	268	230	215	215
q15	500	484	466	466
q16	522	368	379	368
q17	967	700	713	700
q18	7959	7385	7326	7326
q19	5220	1471	1489	1471
q20	645	306	315	306
q21	4731	3845	3877	3845
q22	400	337	323	323
Total cold run time: 115797 ms
Total hot run time: 40199 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4385	4380	4249	4249
q2	376	278	264	264
q3	2952	2857	2888	2857
q4	1944	1664	1627	1627
q5	5605	5510	5473	5473
q6	226	136	141	136
q7	2147	1880	1914	1880
q8	3242	3388	3376	3376
q9	8737	8683	8905	8683
q10	4025	3905	3669	3669
q11	601	499	488	488
q12	810	631	646	631
q13	16261	3160	3152	3152
q14	309	281	273	273
q15	527	475	482	475
q16	498	425	437	425
q17	1798	1500	1509	1500
q18	8066	7870	7776	7776
q19	1828	1554	1646	1554
q20	3123	1891	1861	1861
q21	5258	4990	4697	4697
q22	593	540	543	540
Total cold run time: 73311 ms
Total hot run time: 55586 ms

@doris-robot
Copy link

doris-robot commented Jun 12, 2024

TPC-DS: Total hot run time: 174579 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e30cabec71b96aea093940dc94cfba2214aa66c2, data reload: false

query1	923	371	382	371
query2	6474	2618	2191	2191
query3	6631	210	212	210
query4	18926	17508	17109	17109
query5	3624	463	465	463
query6	241	160	159	159
query7	4580	308	289	289
query8	327	310	282	282
query9	8477	2367	2341	2341
query10	563	293	295	293
query11	10521	10068	10034	10034
query12	130	83	83	83
query13	1634	373	356	356
query14	10164	7658	7868	7658
query15	231	197	182	182
query16	7524	260	264	260
query17	1929	552	543	543
query18	1403	270	276	270
query19	198	160	160	160
query20	90	79	81	79
query21	204	132	129	129
query22	4449	4146	4204	4146
query23	33653	33693	33645	33645
query24	10776	2920	2920	2920
query25	645	406	397	397
query26	729	170	160	160
query27	2324	344	346	344
query28	5652	2075	2081	2075
query29	901	676	669	669
query30	244	159	165	159
query31	997	766	759	759
query32	97	54	60	54
query33	697	321	304	304
query34	891	494	508	494
query35	740	667	678	667
query36	1150	939	971	939
query37	154	79	75	75
query38	3005	2832	2915	2832
query39	935	828	821	821
query40	213	127	125	125
query41	54	53	52	52
query42	116	108	102	102
query43	636	568	575	568
query44	1110	732	758	732
query45	195	163	166	163
query46	1066	724	701	701
query47	1888	1772	1791	1772
query48	375	305	307	305
query49	847	416	413	413
query50	783	442	416	416
query51	6834	6657	6615	6615
query52	98	89	99	89
query53	351	292	285	285
query54	844	454	458	454
query55	75	72	73	72
query56	284	267	263	263
query57	1101	1045	1055	1045
query58	249	235	238	235
query59	3391	3188	3227	3188
query60	311	296	279	279
query61	96	111	90	90
query62	604	438	435	435
query63	319	285	281	281
query64	8542	2252	1744	1744
query65	3163	3076	3073	3073
query66	768	318	335	318
query67	15431	15178	14905	14905
query68	6254	554	545	545
query69	596	467	435	435
query70	1218	1120	1037	1037
query71	469	278	278	278
query72	7216	5562	5650	5562
query73	808	329	325	325
query74	5893	5510	5466	5466
query75	3757	2685	2633	2633
query76	3792	910	972	910
query77	679	307	314	307
query78	10316	9768	9692	9692
query79	2426	533	515	515
query80	1339	476	470	470
query81	550	217	222	217
query82	887	103	103	103
query83	207	172	170	170
query84	282	92	85	85
query85	1216	279	333	279
query86	454	317	302	302
query87	3288	3086	3074	3074
query88	3807	2431	2429	2429
query89	483	372	380	372
query90	1719	198	188	188
query91	132	99	101	99
query92	61	50	53	50
query93	2296	511	508	508
query94	1031	189	187	187
query95	411	313	311	311
query96	601	283	275	275
query97	3237	3093	3092	3092
query98	216	195	192	192
query99	1311	842	829	829
Total cold run time: 269529 ms
Total hot run time: 174579 ms

@doris-robot
Copy link

doris-robot commented Jun 12, 2024

ClickBench: Total hot run time: 30.86 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e30cabec71b96aea093940dc94cfba2214aa66c2, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.49	0.48
query6	1.13	0.71	0.72
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.54	0.48	0.49
query10	0.55	0.55	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.79	0.79	0.77
query15	0.82	0.81	0.83
query16	0.36	0.38	0.37
query17	1.04	0.98	1.04
query18	0.21	0.25	0.23
query19	1.85	1.76	1.76
query20	0.01	0.01	0.01
query21	15.43	0.65	0.65
query22	3.98	7.43	2.30
query23	18.27	1.43	1.18
query24	2.19	0.21	0.22
query25	0.15	0.09	0.09
query26	0.27	0.17	0.17
query27	0.07	0.08	0.08
query28	13.21	1.03	0.98
query29	12.62	3.22	3.21
query30	0.27	0.07	0.07
query31	2.83	0.39	0.38
query32	3.30	0.47	0.47
query33	2.88	2.88	2.93
query34	17.09	4.42	4.41
query35	4.42	4.49	4.54
query36	0.68	0.47	0.47
query37	0.18	0.15	0.15
query38	0.15	0.15	0.15
query39	0.04	0.03	0.04
query40	0.18	0.15	0.15
query41	0.10	0.04	0.04
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.22 s
Total hot run time: 30.86 s

morningman
morningman approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit 315ccb2 into apache:master Jun 12, 2024
morningman pushed a commit to morningman/doris that referenced this pull request Jun 12, 2024
@xiedeyantu @morningman
[minor] better column name error description (apache#36154)
0e7243c 
If column name is count(*), it can only throw 'No field name set', it
not friendly to us.
@morningman morningman mentioned this pull request Jun 12, 2024
Merged
morningman added a commit that referenced this pull request Jun 13, 2024
@morningman @xiedeyantu
[minor] better column name error description (#36154) (#36212)
106a554 
bp #36154

Co-authored-by: Jensen <czjourney@163.com>
dataroaring pushed a commit that referenced this pull request Jun 13, 2024
@xiedeyantu @dataroaring
[minor] better column name error description (#36154)
f38a079 
If column name is count(*), it can only throw 'No field name set', it
not friendly to us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiedeyantu @doris-robot @morningman @wuwenchi @dataroaring