Skip to content

[fix](script) do not prepare lakesoul data when --stop#36181

Merged
hello-stephen merged 3 commits intoapache:masterfrom
hello-stephen:0612-docker
Jun 27, 2024
Merged

[fix](script) do not prepare lakesoul data when --stop#36181
hello-stephen merged 3 commits intoapache:masterfrom
hello-stephen:0612-docker

Conversation

@hello-stephen
Copy link
Contributor

@hello-stephen hello-stephen commented Jun 12, 2024

Proposed changes

Issue Number: close #xxx

It should not run the command to prepare lakesoul data when --stop

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hello-stephen
Copy link
Contributor Author

run buildall

@hello-stephen hello-stephen marked this pull request as draft June 12, 2024 11:38
@hello-stephen
Copy link
Contributor Author

run buildall

@hello-stephen hello-stephen marked this pull request as ready for review June 26, 2024 06:44
@hello-stephen hello-stephen changed the title [fix](script) source it after install rustup [fix](script) do not prepare lakesoul data when --stop Jun 27, 2024
@hello-stephen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor Author

run external

@hello-stephen hello-stephen merged commit eb4d2a9 into apache:master Jun 27, 2024
@hello-stephen hello-stephen deleted the 0612-docker branch June 27, 2024 11:19
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

It should not run the command to prepare lakesoul data when --stop

---------

Co-authored-by: stephen <hello-stephen@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants