[Bug](Function) fix json contains with empty value #36320

eldenmoon · 2024-06-14T11:00:04Z

Proposed changes

0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_release/doris/be/src/common/signal_handler.h:421
1# os::Linux::chained_handler(int, siginfo*, void*) in /root/jdk8/jre/lib/amd64/server/libjvm.so
2# JVM_handle_linux_signal in /root/jdk8/jre/lib/amd64/server/libjvm.so
3# signalHandler(int, siginfo*, void*) in /root/jdk8/jre/lib/amd64/server/libjvm.so
4# 0x00007F8327EF6400 in /lib64/libc.so.6
5# doris::JsonbValue::findValue(doris::JsonbPath&, int ()(char const, unsigned int)) at /home/zcp/repo_center/doris_release/doris/be/src/util/jsonb_document.h:1410
6# doris::vectorized::JsonbContainsUtil::jsonb_contains_execute(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned lon
g, unsigned long) at /home/zcp/repo_center/doris_release/doris/be/src/vec/functions/function_jsonb.cpp:1373
7# doris::vectorized::FunctionJsonbContainsdoris::vectorized::JsonbContainsAndPathImpl::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocato
r > const&, unsigned long, unsigned long) const at /home/zcp/repo_center/doris_release/doris/be/src/vec/functions/function_jsonb.cpp:1309
8# doris::vectorized::DefaultExecutable::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigne
d long) const at /home/zcp/repo_center/doris_release/doris/be/src/vec/functions/function.h:429
9# doris::vectorized::PreparedFunctionImpl::default_implementation_for_constant_arguments(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long, bool, bool*) const at /home/zcp/repo_center/doris_release/doris/be/src/vec/functions/function.cpp:170
10# doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator >
const&, unsigned long, unsigned long, bool) const in /root/apache-doris-2.1.3-bin-x64/be/lib/doris_be
11# doris::vectorized::PreparedFunctionImpl::execute(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned
long, bool) const at /home/zcp/repo_center/doris_release/doris/be/src/vec/functions/function.cpp:250
12# doris::vectorized::IFunctionBase::execute(doris::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long, b
ool) const at
Issue Number: close #xxx

doris-robot · 2024-06-14T11:00:10Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon · 2024-06-14T11:00:12Z

run buildall

eldenmoon · 2024-06-14T11:00:25Z

run buildall

github-actions · 2024-06-14T11:05:54Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-06-14T11:17:51Z

TPC-H: Total hot run time: 39971 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 619455562146b27857af7d58c838747053889d81, data reload: false

------ Round 1 ----------------------------------
q1	18062	4456	4355	4355
q2	2625	196	192	192
q3	12041	1121	1090	1090
q4	10252	827	823	823
q5	7843	2669	2651	2651
q6	224	143	141	141
q7	978	631	617	617
q8	9580	2054	2029	2029
q9	8782	6505	6486	6486
q10	9041	3714	3710	3710
q11	453	242	235	235
q12	420	236	225	225
q13	17889	2970	3004	2970
q14	258	227	220	220
q15	512	488	494	488
q16	513	386	378	378
q17	957	692	663	663
q18	8129	7526	7403	7403
q19	7242	1488	1502	1488
q20	646	313	336	313
q21	4798	3275	3166	3166
q22	390	341	328	328
Total cold run time: 121635 ms
Total hot run time: 39971 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4389	4268	4209	4209
q2	389	280	271	271
q3	2961	2716	2718	2716
q4	1875	1604	1635	1604
q5	5255	5232	5262	5232
q6	212	125	129	125
q7	2118	1711	1731	1711
q8	3187	3284	3292	3284
q9	8366	8261	8329	8261
q10	3888	3635	3643	3635
q11	604	488	473	473
q12	761	578	581	578
q13	16696	2993	3011	2993
q14	295	262	268	262
q15	524	474	481	474
q16	477	409	433	409
q17	1784	1496	1473	1473
q18	7503	7571	7356	7356
q19	1670	1595	1544	1544
q20	1986	1833	1790	1790
q21	4890	4841	4663	4663
q22	602	550	535	535
Total cold run time: 70432 ms
Total hot run time: 53598 ms

doris-robot · 2024-06-14T11:22:39Z

TeamCity be ut coverage result:
Function Coverage: 36.45% (8989/24661)
Line Coverage: 28.02% (73687/262947)
Region Coverage: 27.49% (38267/139219)
Branch Coverage: 24.19% (19510/80666)
Coverage Report: http://coverage.selectdb-in.cc/coverage/619455562146b27857af7d58c838747053889d81_619455562146b27857af7d58c838747053889d81/report/index.html

doris-robot · 2024-06-14T11:28:53Z

TPC-DS: Total hot run time: 172670 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 619455562146b27857af7d58c838747053889d81, data reload: false

query1	938	378	380	378
query2	6460	2360	2335	2335
query3	6653	207	204	204
query4	19458	17584	17305	17305
query5	4157	477	499	477
query6	245	159	155	155
query7	4553	302	295	295
query8	326	296	293	293
query9	8317	2412	2367	2367
query10	619	327	298	298
query11	10682	10079	10065	10065
query12	135	94	92	92
query13	1624	374	370	370
query14	9492	7745	7011	7011
query15	260	190	200	190
query16	8041	266	258	258
query17	1931	531	522	522
query18	2046	285	272	272
query19	195	157	154	154
query20	93	87	80	80
query21	209	127	124	124
query22	4440	4185	4039	4039
query23	33797	33277	33112	33112
query24	12024	2840	2811	2811
query25	639	376	362	362
query26	1782	157	154	154
query27	2982	323	316	316
query28	7469	2023	2029	2023
query29	1045	632	614	614
query30	293	153	150	150
query31	978	739	755	739
query32	106	57	56	56
query33	747	279	283	279
query34	947	466	455	455
query35	748	634	632	632
query36	1084	928	925	925
query37	305	73	73	73
query38	2893	2734	2709	2709
query39	866	801	814	801
query40	291	135	160	135
query41	54	52	51	51
query42	121	100	101	100
query43	595	539	547	539
query44	1235	729	740	729
query45	202	162	168	162
query46	1063	717	712	712
query47	1872	1783	1780	1780
query48	364	303	295	295
query49	1188	415	403	403
query50	771	381	387	381
query51	6835	6763	6680	6680
query52	104	97	93	93
query53	359	305	286	286
query54	935	445	440	440
query55	75	72	76	72
query56	287	263	267	263
query57	1160	1055	1030	1030
query58	263	234	258	234
query59	3555	3012	3351	3012
query60	290	276	277	276
query61	92	92	88	88
query62	678	438	436	436
query63	330	285	291	285
query64	9858	2300	1743	1743
query65	3207	3172	3102	3102
query66	1364	332	334	332
query67	15413	15322	14849	14849
query68	4622	551	539	539
query69	466	313	322	313
query70	1181	1116	1087	1087
query71	389	284	271	271
query72	7202	5160	5533	5160
query73	746	318	324	318
query74	6079	5572	5544	5544
query75	3456	2651	2688	2651
query76	2618	1049	988	988
query77	499	307	348	307
query78	10410	9831	9858	9831
query79	2272	523	530	523
query80	993	474	469	469
query81	583	222	234	222
query82	754	107	104	104
query83	238	170	171	170
query84	232	87	86	86
query85	2011	293	266	266
query86	496	337	323	323
query87	3284	3095	3083	3083
query88	4266	2358	2334	2334
query89	473	385	387	385
query90	1825	190	189	189
query91	133	98	102	98
query92	65	51	50	50
query93	2418	521	492	492
query94	1270	198	199	198
query95	418	372	317	317
query96	586	263	266	263
query97	3241	3027	3040	3027
query98	223	206	204	204
query99	1177	858	855	855
Total cold run time: 276766 ms
Total hot run time: 172670 ms

doris-robot · 2024-06-14T11:34:24Z

ClickBench: Total hot run time: 30.71 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 619455562146b27857af7d58c838747053889d81, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.28	0.04	0.05
query4	2.11	0.08	0.08
query5	0.50	0.50	0.49
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.55	0.54
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.58	0.60	0.60
query14	0.77	0.79	0.80
query15	0.83	0.82	0.81
query16	0.35	0.36	0.36
query17	0.96	0.99	1.01
query18	0.26	0.23	0.25
query19	1.80	1.71	1.76
query20	0.01	0.01	0.01
query21	15.41	0.65	0.64
query22	5.44	6.28	2.02
query23	18.28	1.31	1.24
query24	2.12	0.21	0.22
query25	0.15	0.08	0.08
query26	0.28	0.18	0.17
query27	0.07	0.08	0.09
query28	13.27	1.02	0.99
query29	12.59	3.26	3.27
query30	0.26	0.07	0.06
query31	2.84	0.38	0.38
query32	3.27	0.48	0.47
query33	2.95	2.97	2.97
query34	17.20	4.48	4.42
query35	4.50	4.50	4.46
query36	0.66	0.46	0.50
query37	0.20	0.15	0.15
query38	0.14	0.14	0.15
query39	0.05	0.04	0.03
query40	0.17	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 111.21 s
Total hot run time: 30.71 s

superdiaodiao · 2024-06-15T10:30:56Z

regression-test/suites/query_p0/sql_functions/json_functions/test_json_function.groovy

-
+    qt_sql """SELECT JSON_CONTAINS('','1','\$.a')"""
+    qt_sql """SELECT JSON_CONTAINS('""','1','\$.a')"""
+    qt_sql """SELECT JSON_CONTAINS("",'1','\$.a')"""


Hi, what about adding the test for NULL by the way?

xiaokang

LGTM

github-actions · 2024-06-16T02:58:37Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-06-16T02:58:39Z

PR approved by anyone and no changes requested.

qidaye

LGTM

…ache#36416)

[Bug](Function) fix json contains with empty value

6194555

eldenmoon added the dev/2.1.x label Jun 14, 2024

superdiaodiao reviewed Jun 15, 2024

View reviewed changes

xiaokang approved these changes Jun 16, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 16, 2024

github-actions bot added the reviewed label Jun 16, 2024

qidaye approved these changes Jun 17, 2024

View reviewed changes

eldenmoon merged commit a9e2a92 into apache:master Jun 17, 2024

eldenmoon added the dev/2.0.x label Jun 17, 2024

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jun 17, 2024

[Bug](Function) fix json contains with empty value (apache#36320)

b1edf6f

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jun 17, 2024

[Bug](Function) fix json contains with empty value (apache#36320)

79f62d4

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jun 17, 2024

[Bug](Function) fix json contains with empty value (apache#36320)

c951eda

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jun 17, 2024

[Bug](Function) fix json contains with empty value (apache#36320)

1e12f86

xiaokang pushed a commit that referenced this pull request Jun 18, 2024

[Bug](Function) fix json contains with empty value (#36320) (#36416)

6a9fe27

xiaokang mentioned this pull request Jun 18, 2024

[Bug](Function) fix json contains with empty value (#36320) #36416

Merged

xiaokang added dev/2.0.12-merged and removed dev/2.0.x labels Jun 18, 2024

xiaokang pushed a commit that referenced this pull request Jun 18, 2024

[Bug](Function) fix json contains with empty value (#36320) (#36418)

4a11780

xiaokang mentioned this pull request Jun 18, 2024

[Bug](Function) fix json contains with empty value (#36320) #36418

Merged

xiaokang removed the dev/2.1.x label Jun 18, 2024

xiaokang added the dev/2.1.4-merged label Jun 18, 2024

eldenmoon deleted the fix-json-contains branch June 18, 2024 06:27

dataroaring pushed a commit that referenced this pull request Jun 21, 2024

[Bug](Function) fix json contains with empty value (#36320)

6abe02e

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024

[Bug](Function) fix json contains with empty value (apache#36320) (ap…

ae60a25

…ache#36416)

[Bug](Function) fix json contains with empty value #36320

[Bug](Function) fix json contains with empty value #36320

Uh oh!

Conversation

eldenmoon commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Jun 14, 2024

Uh oh!

eldenmoon commented Jun 14, 2024

Uh oh!

eldenmoon commented Jun 14, 2024

Uh oh!

github-actions bot commented Jun 14, 2024

Uh oh!

doris-robot commented Jun 14, 2024

Uh oh!

doris-robot commented Jun 14, 2024

Uh oh!

doris-robot commented Jun 14, 2024

Uh oh!

doris-robot commented Jun 14, 2024

Uh oh!

superdiaodiao Jun 15, 2024

Choose a reason for hiding this comment

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 16, 2024

Uh oh!

github-actions bot commented Jun 16, 2024

Uh oh!

qidaye left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eldenmoon commented Jun 14, 2024 •

edited

Loading