Skip to content

[fix](nereids) fix localtime etc. show wrong title#36333

Closed
Dragonliu2018 wants to merge 1 commit intoapache:masterfrom
Dragonliu2018:dragonliu/fix_localtime_show_info
Closed

[fix](nereids) fix localtime etc. show wrong title#36333
Dragonliu2018 wants to merge 1 commit intoapache:masterfrom
Dragonliu2018:dragonliu/fix_localtime_show_info

Conversation

@Dragonliu2018
Copy link
Contributor

@Dragonliu2018 Dragonliu2018 commented Jun 14, 2024

Proposed changes

Issue Number: close #36332

before:

mysql> SET enable_nereids_planner=true;
mysql> select current_timestamp();
+---------------------+
| now()               |
+---------------------+
| 2024-06-13 23:39:23 |
+---------------------+
1 row in set (0.00 sec)

current:

mysql> SET enable_nereids_planner=true;
mysql> select current_timestamp();
+---------------------+
| current_timestamp() |
+---------------------+
| 2024-06-14 10:09:01 |
+---------------------+
1 row in set (0.01 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Dragonliu2018
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39572 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0396db8ffe2f485c88065cd4b170bb14e0b9ffd3, data reload: false

------ Round 1 ----------------------------------
q1	17622	4305	4241	4241
q2	2014	182	192	182
q3	10467	1090	1082	1082
q4	10182	708	766	708
q5	7490	2638	2541	2541
q6	217	132	132	132
q7	964	608	595	595
q8	9229	2052	2033	2033
q9	9000	6451	6448	6448
q10	8957	3665	3753	3665
q11	452	232	243	232
q12	467	228	227	227
q13	17776	2993	3018	2993
q14	255	213	217	213
q15	514	482	467	467
q16	525	377	375	375
q17	948	672	641	641
q18	8006	7428	7478	7428
q19	6210	1507	1534	1507
q20	645	309	307	307
q21	4953	3230	3217	3217
q22	397	338	346	338
Total cold run time: 117290 ms
Total hot run time: 39572 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4476	4232	4259	4232
q2	356	270	263	263
q3	2962	2883	2973	2883
q4	1945	1706	1611	1611
q5	5600	5482	5467	5467
q6	219	128	127	127
q7	2195	1872	1833	1833
q8	3279	3419	3419	3419
q9	8652	8629	8845	8629
q10	4079	3900	3708	3708
q11	596	492	509	492
q12	801	632	645	632
q13	17298	3139	3171	3139
q14	325	269	284	269
q15	524	511	492	492
q16	501	422	430	422
q17	1814	1502	1480	1480
q18	8019	8003	7740	7740
q19	1812	1497	1678	1497
q20	3261	1862	1871	1862
q21	5125	4854	4863	4854
q22	678	564	565	564
Total cold run time: 74517 ms
Total hot run time: 55615 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171477 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0396db8ffe2f485c88065cd4b170bb14e0b9ffd3, data reload: false

query1	936	367	366	366
query2	6452	2428	2465	2428
query3	6638	207	206	206
query4	19378	17454	17246	17246
query5	3644	465	455	455
query6	239	170	146	146
query7	4581	303	289	289
query8	355	322	292	292
query9	8400	2362	2350	2350
query10	565	293	284	284
query11	10446	10111	10008	10008
query12	118	82	83	82
query13	1636	356	356	356
query14	10142	6532	6814	6532
query15	242	188	190	188
query16	7138	269	259	259
query17	1473	552	516	516
query18	1827	279	275	275
query19	195	164	161	161
query20	92	87	83	83
query21	210	131	127	127
query22	4273	4008	3973	3973
query23	33758	33511	33479	33479
query24	11305	2869	2888	2869
query25	619	375	380	375
query26	715	155	150	150
query27	2322	329	328	328
query28	5970	2082	2080	2080
query29	892	631	603	603
query30	254	159	156	156
query31	970	747	740	740
query32	87	52	53	52
query33	775	285	273	273
query34	1082	474	509	474
query35	745	656	652	652
query36	1137	961	955	955
query37	144	73	69	69
query38	2934	2816	2811	2811
query39	908	886	841	841
query40	208	134	128	128
query41	54	52	56	52
query42	108	102	101	101
query43	593	534	571	534
query44	1146	711	711	711
query45	197	163	162	162
query46	1070	728	707	707
query47	1866	1787	1822	1787
query48	354	286	287	286
query49	836	393	407	393
query50	762	385	381	381
query51	6819	6646	6650	6646
query52	106	86	89	86
query53	351	290	279	279
query54	919	437	432	432
query55	73	72	70	70
query56	269	257	257	257
query57	1123	1045	1081	1045
query58	252	252	237	237
query59	3446	3394	3035	3035
query60	306	293	298	293
query61	116	110	111	110
query62	614	476	433	433
query63	310	286	286	286
query64	8816	2210	1718	1718
query65	3203	3077	3064	3064
query66	899	326	323	323
query67	15454	15095	14883	14883
query68	4556	529	537	529
query69	637	456	385	385
query70	1179	1099	1020	1020
query71	423	265	311	265
query72	8016	5518	4697	4697
query73	741	316	319	316
query74	5891	5523	5443	5443
query75	3379	2661	2636	2636
query76	2719	988	887	887
query77	633	289	289	289
query78	10869	9736	9629	9629
query79	3163	505	492	492
query80	2046	453	449	449
query81	593	223	220	220
query82	817	100	99	99
query83	361	168	167	167
query84	278	84	81	81
query85	1381	284	269	269
query86	465	294	314	294
query87	3276	3070	3098	3070
query88	4461	2308	2321	2308
query89	496	385	369	369
query90	1704	183	182	182
query91	126	96	95	95
query92	62	46	50	46
query93	4860	511	501	501
query94	1103	182	254	182
query95	408	314	314	314
query96	598	259	257	257
query97	3267	2998	3107	2998
query98	220	195	199	195
query99	1325	851	825	825
Total cold run time: 273920 ms
Total hot run time: 171477 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.03 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0396db8ffe2f485c88065cd4b170bb14e0b9ffd3, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.51	0.48	0.50
query6	1.13	0.72	0.72
query7	0.03	0.01	0.01
query8	0.05	0.05	0.04
query9	0.53	0.50	0.48
query10	0.56	0.56	0.55
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.59	0.59
query14	0.82	0.77	0.79
query15	0.84	0.80	0.81
query16	0.35	0.36	0.35
query17	1.07	0.96	0.99
query18	0.23	0.26	0.23
query19	1.78	1.74	1.68
query20	0.01	0.01	0.01
query21	15.41	0.65	0.64
query22	4.26	6.88	2.39
query23	18.29	1.42	1.38
query24	2.11	0.25	0.22
query25	0.14	0.08	0.07
query26	0.26	0.18	0.17
query27	0.09	0.08	0.08
query28	13.18	1.02	1.01
query29	12.64	3.26	3.27
query30	0.26	0.06	0.06
query31	2.88	0.38	0.37
query32	3.28	0.47	0.46
query33	2.95	2.87	2.90
query34	16.99	4.42	4.44
query35	4.51	4.49	4.46
query36	0.65	0.48	0.47
query37	0.18	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.04
query40	0.17	0.14	0.14
query41	0.09	0.06	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.47 s
Total hot run time: 31.03 s

@zclllyybb
Copy link
Contributor

@morrySnow PTAL and check if this is proper

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we could solve this problem by a better way. copy code is not a good idea

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Dec 15, 2024
@github-actions github-actions bot closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] localtime etc. funcs in nereids dispaly wrong title.

4 participants