Skip to content

[Performance](exec) Fix sin performance problem #36358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 1 commit into from
Jun 17, 2024
Merged

[Performance](exec) Fix sin performance problem #36358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions be/src/vec/functions/math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#include <cstring>

// IWYU pragma: no_include <bits/std_abs.h>
#include <dlfcn.h>

#include <cmath>
#include <string>
#include <type_traits>
Expand Down Expand Up @@ -214,10 +216,29 @@ struct NamePositive {

using FunctionPositive = FunctionUnaryArithmetic<PositiveImpl, NamePositive>;

struct SinName {
struct UnaryFunctionPlainSin {
using Type = DataTypeFloat64;
static constexpr auto name = "sin";
using FuncType = double (*)(double);

static FuncType get_sin_func() {
void* handle = dlopen("libm.so.6", RTLD_LAZY);
if (handle) {
if (auto sin_func = (double (*)(double))dlsym(handle, "sin"); sin_func) {
return sin_func;
}
dlclose(handle);
}
return std::sin;
}

static void execute(const double* src, double* dst) {
static auto sin_func = get_sin_func();
*dst = sin_func(*src);
}
};
using FunctionSin = FunctionMathUnary<UnaryFunctionPlain<SinName, std::sin>>;

using FunctionSin = FunctionMathUnary<UnaryFunctionPlainSin>;

struct SqrtName {
static constexpr auto name = "sqrt";
Expand Down