Skip to content

[Enhancement](group commit) Use async group commit rpc call#36499

Merged
dataroaring merged 3 commits intoapache:masterfrom
Yukang-Lian:Use_Async_Group_Commit_Rpc_Call
Jun 21, 2024
Merged

[Enhancement](group commit) Use async group commit rpc call#36499
dataroaring merged 3 commits intoapache:masterfrom
Yukang-Lian:Use_Async_Group_Commit_Rpc_Call

Conversation

@Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Jun 18, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jun 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.47% (9004/24686)
Line Coverage: 28.02% (73766/263240)
Region Coverage: 27.50% (38321/139350)
Branch Coverage: 24.20% (19533/80712)
Coverage Report: http://coverage.selectdb-in.cc/coverage/690c8ab892c8b8a9c78544040e5afaeda15b6ccb_690c8ab892c8b8a9c78544040e5afaeda15b6ccb/report/index.html

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

TPC-H: Total hot run time: 39852 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false

------ Round 1 ----------------------------------
q1	17616	4364	4300	4300
q2	2024	186	193	186
q3	10463	1138	1125	1125
q4	10180	781	823	781
q5	7481	2694	2656	2656
q6	222	136	133	133
q7	955	622	591	591
q8	9232	2078	2094	2078
q9	8900	6491	6490	6490
q10	9010	3701	3724	3701
q11	447	238	235	235
q12	486	233	229	229
q13	17773	3006	2981	2981
q14	274	217	217	217
q15	511	481	471	471
q16	523	373	376	373
q17	980	689	695	689
q18	7938	7418	7432	7418
q19	2516	1449	1513	1449
q20	650	311	338	311
q21	5004	3100	3830	3100
q22	379	345	338	338
Total cold run time: 113564 ms
Total hot run time: 39852 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4412	4291	4248	4248
q2	371	255	261	255
q3	2963	2725	2874	2725
q4	1982	1709	1699	1699
q5	5533	5553	5463	5463
q6	210	127	126	126
q7	2239	1805	1900	1805
q8	3296	3433	3451	3433
q9	8701	8629	8794	8629
q10	4125	3893	3811	3811
q11	567	490	505	490
q12	796	603	642	603
q13	15853	3208	3210	3208
q14	292	280	278	278
q15	547	483	473	473
q16	495	421	419	419
q17	1836	1519	1490	1490
q18	8181	7974	7829	7829
q19	1785	1625	1498	1498
q20	2138	1856	1883	1856
q21	10605	4813	4968	4813
q22	626	526	541	526
Total cold run time: 77553 ms
Total hot run time: 55677 ms

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

TPC-DS: Total hot run time: 173127 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false

query1	913	381	377	377
query2	6452	2351	2388	2351
query3	6632	205	206	205
query4	21439	17336	17310	17310
query5	3617	467	471	467
query6	238	157	157	157
query7	4596	303	300	300
query8	330	284	287	284
query9	8651	2386	2375	2375
query10	553	324	280	280
query11	10351	10106	10006	10006
query12	119	85	81	81
query13	1636	364	356	356
query14	10019	7687	6966	6966
query15	239	209	205	205
query16	7719	271	264	264
query17	1911	529	517	517
query18	1986	317	272	272
query19	191	167	146	146
query20	93	91	83	83
query21	208	126	124	124
query22	4388	4165	4155	4155
query23	33901	33618	33365	33365
query24	10667	2943	2910	2910
query25	638	370	379	370
query26	710	154	152	152
query27	2305	333	330	330
query28	6036	2114	2094	2094
query29	869	624	633	624
query30	268	154	154	154
query31	987	766	756	756
query32	95	55	58	55
query33	671	324	275	275
query34	903	485	474	474
query35	757	638	620	620
query36	1150	984	992	984
query37	143	71	69	69
query38	2983	2838	2843	2838
query39	907	829	852	829
query40	208	128	131	128
query41	55	55	56	55
query42	126	103	98	98
query43	569	566	530	530
query44	1107	721	724	721
query45	198	160	163	160
query46	1075	740	701	701
query47	1889	1758	1768	1758
query48	384	297	292	292
query49	830	396	413	396
query50	759	384	385	384
query51	6814	6641	6694	6641
query52	99	96	93	93
query53	365	285	291	285
query54	875	439	453	439
query55	76	72	70	70
query56	277	250	258	250
query57	1131	1022	1068	1022
query58	259	241	237	237
query59	3339	3074	3001	3001
query60	292	261	286	261
query61	94	89	113	89
query62	595	465	442	442
query63	315	299	290	290
query64	8556	2239	1753	1753
query65	3182	3114	3092	3092
query66	743	328	323	323
query67	15451	15042	14932	14932
query68	4521	534	540	534
query69	488	363	332	332
query70	1198	1155	1147	1147
query71	377	276	316	276
query72	6943	5253	5521	5253
query73	730	330	335	330
query74	5876	5481	5489	5481
query75	3424	2604	2695	2604
query76	2210	919	890	890
query77	419	297	306	297
query78	10176	9892	9821	9821
query79	2135	517	519	517
query80	1011	450	453	450
query81	547	218	222	218
query82	888	102	97	97
query83	221	164	161	161
query84	231	84	83	83
query85	1765	307	279	279
query86	478	336	306	306
query87	3265	3071	3056	3056
query88	4300	2368	2344	2344
query89	485	402	389	389
query90	1706	185	191	185
query91	128	99	102	99
query92	61	48	48	48
query93	2495	501	507	501
query94	1054	199	193	193
query95	418	328	322	322
query96	598	270	263	263
query97	3213	3028	3008	3008
query98	220	201	202	201
query99	1353	819	837	819
Total cold run time: 268868 ms
Total hot run time: 173127 ms

@doris-robot
Copy link

doris-robot commented Jun 18, 2024

ClickBench: Total hot run time: 30.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.08	0.07
query5	0.51	0.48	0.48
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.05
query9	0.56	0.49	0.48
query10	0.54	0.56	0.54
query11	0.14	0.11	0.11
query12	0.14	0.11	0.12
query13	0.58	0.58	0.59
query14	0.79	0.77	0.81
query15	0.82	0.80	0.82
query16	0.37	0.37	0.36
query17	1.00	0.96	0.98
query18	0.23	0.22	0.24
query19	1.89	1.82	1.69
query20	0.01	0.01	0.01
query21	15.42	0.65	0.66
query22	4.01	6.95	2.11
query23	18.32	1.28	1.24
query24	2.20	0.21	0.21
query25	0.16	0.10	0.10
query26	0.26	0.18	0.17
query27	0.08	0.08	0.09
query28	13.25	1.01	0.99
query29	12.67	3.28	3.19
query30	0.26	0.06	0.06
query31	2.90	0.38	0.39
query32	3.25	0.47	0.48
query33	2.86	2.95	2.89
query34	17.02	4.37	4.37
query35	4.52	4.50	4.44
query36	0.66	0.47	0.45
query37	0.17	0.15	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.34 s
Total hot run time: 30.45 s

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jun 19, 2024

run p1

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jun 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (9002/24694)
Line Coverage: 28.01% (73775/263419)
Region Coverage: 27.49% (38330/139421)
Branch Coverage: 24.19% (19537/80780)
Coverage Report: http://coverage.selectdb-in.cc/coverage/68310be76bcbd2c7bcc622f4a7d380770985f738_68310be76bcbd2c7bcc622f4a7d380770985f738/report/index.html

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TPC-H: Total hot run time: 40978 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68310be76bcbd2c7bcc622f4a7d380770985f738, data reload: false

------ Round 1 ----------------------------------
q1	17606	4529	4351	4351
q2	2035	190	195	190
q3	10518	1195	1087	1087
q4	10214	781	788	781
q5	7541	2764	2748	2748
q6	224	140	141	140
q7	1006	616	605	605
q8	9222	2108	2130	2108
q9	8960	6580	6428	6428
q10	9012	3757	3769	3757
q11	453	246	236	236
q12	485	237	243	237
q13	17766	2995	2987	2987
q14	268	212	225	212
q15	513	479	485	479
q16	521	380	380	380
q17	990	651	718	651
q18	8114	7523	7490	7490
q19	4599	1431	1443	1431
q20	652	332	335	332
q21	5127	4012	4081	4012
q22	418	336	340	336
Total cold run time: 116244 ms
Total hot run time: 40978 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4451	4316	4308	4308
q2	372	267	266	266
q3	3028	2959	2914	2914
q4	2015	1720	1761	1720
q5	5626	5553	5518	5518
q6	226	144	142	142
q7	2259	1902	1874	1874
q8	3358	3488	3471	3471
q9	8765	8815	8828	8815
q10	4139	3811	3803	3803
q11	616	507	489	489
q12	834	649	630	630
q13	17012	3187	3184	3184
q14	308	282	259	259
q15	547	482	482	482
q16	507	419	426	419
q17	1853	1542	1503	1503
q18	8155	7780	7821	7780
q19	4211	1685	1729	1685
q20	2094	1907	1879	1879
q21	5186	4985	4749	4749
q22	605	565	571	565
Total cold run time: 76167 ms
Total hot run time: 56455 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TPC-DS: Total hot run time: 174170 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68310be76bcbd2c7bcc622f4a7d380770985f738, data reload: false

query1	962	387	381	381
query2	6462	2396	2267	2267
query3	6647	206	208	206
query4	20467	17395	17250	17250
query5	3631	471	475	471
query6	245	165	159	159
query7	4586	304	291	291
query8	316	285	270	270
query9	8505	2388	2373	2373
query10	572	313	314	313
query11	10504	9971	9955	9955
query12	117	90	87	87
query13	1636	373	387	373
query14	10103	7715	7479	7479
query15	253	198	197	197
query16	8016	284	283	283
query17	1830	566	542	542
query18	2149	286	281	281
query19	213	157	158	157
query20	105	82	89	82
query21	211	140	144	140
query22	4701	4456	4449	4449
query23	34308	33445	33547	33445
query24	11281	2816	2869	2816
query25	606	348	357	348
query26	1319	156	153	153
query27	2930	321	307	307
query28	7205	2031	2017	2017
query29	869	608	606	606
query30	248	151	150	150
query31	942	703	745	703
query32	97	52	57	52
query33	741	288	272	272
query34	890	480	468	468
query35	716	595	620	595
query36	1072	969	970	969
query37	159	68	73	68
query38	2853	2749	2752	2749
query39	873	810	819	810
query40	212	131	127	127
query41	55	52	48	48
query42	119	98	101	98
query43	598	557	550	550
query44	1296	739	750	739
query45	198	168	161	161
query46	1094	734	735	734
query47	1878	1755	1764	1755
query48	384	298	299	298
query49	870	463	410	410
query50	771	385	391	385
query51	6793	6737	6774	6737
query52	103	97	93	93
query53	356	293	293	293
query54	888	441	433	433
query55	74	74	74	74
query56	283	252	258	252
query57	1157	1049	1038	1038
query58	260	278	251	251
query59	3437	3240	3349	3240
query60	295	280	280	280
query61	97	96	94	94
query62	623	453	456	453
query63	349	297	294	294
query64	8871	2264	1721	1721
query65	3172	3102	3075	3075
query66	827	326	323	323
query67	15287	15043	14985	14985
query68	4483	535	527	527
query69	518	393	389	389
query70	1123	1165	1133	1133
query71	418	318	279	279
query72	6976	5878	5359	5359
query73	762	324	328	324
query74	5855	5468	5455	5455
query75	3420	2652	2690	2652
query76	2646	980	935	935
query77	721	300	311	300
query78	10723	9721	9770	9721
query79	2322	517	523	517
query80	1818	494	471	471
query81	589	220	220	220
query82	755	115	101	101
query83	326	166	165	165
query84	272	85	82	82
query85	1927	302	276	276
query86	491	327	320	320
query87	3238	3063	3087	3063
query88	4140	2339	2341	2339
query89	473	390	381	381
query90	1736	194	190	190
query91	130	118	102	102
query92	64	52	56	52
query93	2317	509	504	504
query94	1179	192	187	187
query95	412	312	318	312
query96	598	274	263	263
query97	3279	3036	3088	3036
query98	217	207	198	198
query99	1355	860	842	842
Total cold run time: 274970 ms
Total hot run time: 174170 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

ClickBench: Total hot run time: 31.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68310be76bcbd2c7bcc622f4a7d380770985f738, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.06	0.06
query4	1.67	0.07	0.08
query5	0.47	0.47	0.47
query6	1.13	0.74	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.54	0.55	0.52
query11	0.16	0.11	0.12
query12	0.15	0.13	0.13
query13	0.60	0.58	0.58
query14	0.78	0.77	0.79
query15	0.83	0.80	0.82
query16	0.36	0.37	0.37
query17	0.99	0.98	1.00
query18	0.22	0.24	0.26
query19	1.76	1.72	1.72
query20	0.01	0.00	0.01
query21	15.44	0.67	0.66
query22	3.66	7.74	2.15
query23	18.30	1.36	1.26
query24	2.18	0.22	0.20
query25	0.15	0.09	0.08
query26	0.26	0.18	0.18
query27	0.09	0.08	0.08
query28	13.21	1.03	1.03
query29	12.62	3.35	3.33
query30	0.26	0.07	0.06
query31	2.89	0.40	0.38
query32	3.25	0.48	0.48
query33	2.88	2.88	2.90
query34	17.23	4.72	4.63
query35	4.80	4.67	4.55
query36	0.64	0.45	0.48
query37	0.17	0.15	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.17	0.15	0.15
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.23 s
Total hot run time: 31.18 s

@Yukang-Lian Yukang-Lian force-pushed the Use_Async_Group_Commit_Rpc_Call branch from 68310be to 4d522c7 Compare June 20, 2024 16:18
@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jun 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 20, 2024

TeamCity be ut coverage result:
Function Coverage: 36.48% (9009/24695)
Line Coverage: 28.03% (73889/263610)
Region Coverage: 27.51% (38374/139483)
Branch Coverage: 24.22% (19565/80788)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d522c7264304cdc4a03509ffb86c3ef0472431b_4d522c7264304cdc4a03509ffb86c3ef0472431b/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jun 20, 2024

run performance

@doris-robot
Copy link

doris-robot commented Jun 20, 2024

TPC-H: Total hot run time: 42314 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d522c7264304cdc4a03509ffb86c3ef0472431b, data reload: false

------ Round 1 ----------------------------------
q1	17601	4772	4750	4750
q2	2025	186	192	186
q3	10474	1171	1141	1141
q4	10188	813	790	790
q5	7519	2876	2907	2876
q6	246	136	133	133
q7	1053	604	586	586
q8	9226	2250	2249	2249
q9	9056	6913	6888	6888
q10	9128	3918	3863	3863
q11	472	244	233	233
q12	543	230	230	230
q13	18636	2953	2968	2953
q14	276	211	214	211
q15	532	477	476	476
q16	543	375	368	368
q17	1011	677	823	677
q18	8036	7535	7442	7442
q19	8518	1681	1579	1579
q20	672	319	321	319
q21	5209	4029	4065	4029
q22	397	335	341	335
Total cold run time: 121361 ms
Total hot run time: 42314 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4843	4710	4900	4710
q2	396	266	265	265
q3	3305	2974	3033	2974
q4	2105	1798	1719	1719
q5	5640	5730	5688	5688
q6	244	132	128	128
q7	2351	1860	1853	1853
q8	3544	3734	3669	3669
q9	9416	9216	9112	9112
q10	4184	3907	3922	3907
q11	603	479	498	479
q12	840	637	639	637
q13	16904	3157	3156	3156
q14	309	279	275	275
q15	546	476	505	476
q16	509	433	427	427
q17	1956	1601	1582	1582
q18	8199	8034	7776	7776
q19	1988	1747	1873	1747
q20	3079	1880	1819	1819
q21	5353	4917	5195	4917
q22	652	561	535	535
Total cold run time: 76966 ms
Total hot run time: 57851 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2024

TPC-DS: Total hot run time: 173155 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d522c7264304cdc4a03509ffb86c3ef0472431b, data reload: false

query1	946	384	397	384
query2	6396	2364	2309	2309
query3	6631	207	209	207
query4	19498	17287	17235	17235
query5	3617	480	470	470
query6	237	165	162	162
query7	4579	305	291	291
query8	325	304	280	280
query9	8661	2437	2455	2437
query10	562	302	270	270
query11	10440	10154	9938	9938
query12	120	90	82	82
query13	1635	362	354	354
query14	9734	6935	7344	6935
query15	246	204	187	187
query16	7804	271	280	271
query17	1562	565	533	533
query18	1944	307	294	294
query19	211	168	162	162
query20	97	83	86	83
query21	209	125	131	125
query22	4529	4682	4313	4313
query23	34462	33511	33585	33511
query24	11172	2781	2789	2781
query25	604	355	353	353
query26	978	150	150	150
query27	2269	311	305	305
query28	6326	2078	2053	2053
query29	878	612	603	603
query30	251	150	153	150
query31	941	719	731	719
query32	91	80	53	53
query33	750	269	271	269
query34	907	464	463	463
query35	711	610	594	594
query36	1083	947	939	939
query37	133	68	71	68
query38	2856	2756	2722	2722
query39	851	809	822	809
query40	214	122	121	121
query41	55	50	53	50
query42	114	99	97	97
query43	581	560	565	560
query44	1192	715	733	715
query45	194	164	161	161
query46	1065	702	718	702
query47	1897	1775	1787	1775
query48	360	297	294	294
query49	832	397	418	397
query50	762	384	386	384
query51	6885	6791	6749	6749
query52	108	92	99	92
query53	350	293	283	283
query54	872	447	438	438
query55	73	77	76	76
query56	306	280	282	280
query57	1120	1044	1044	1044
query58	264	261	252	252
query59	3426	3197	3163	3163
query60	329	292	349	292
query61	92	93	88	88
query62	582	429	460	429
query63	314	279	283	279
query64	8759	2242	1781	1781
query65	3157	3125	3129	3125
query66	711	324	330	324
query67	15254	14919	15153	14919
query68	4545	533	526	526
query69	469	345	324	324
query70	1140	1083	1087	1083
query71	397	278	273	273
query72	7056	5694	5339	5339
query73	752	314	316	314
query74	5918	5440	5489	5440
query75	3340	2645	2629	2629
query76	2288	945	875	875
query77	431	292	290	290
query78	10369	9766	9871	9766
query79	2627	505	504	504
query80	1128	459	460	459
query81	593	216	218	216
query82	724	102	101	101
query83	238	166	183	166
query84	235	90	84	84
query85	1773	300	274	274
query86	485	323	310	310
query87	3261	3069	3073	3069
query88	3929	2349	2332	2332
query89	475	385	383	383
query90	1692	201	191	191
query91	133	100	100	100
query92	62	48	52	48
query93	2136	487	485	485
query94	955	185	183	183
query95	399	305	308	305
query96	594	263	259	259
query97	3201	3049	3045	3045
query98	228	196	221	196
query99	1218	852	852	852
Total cold run time: 267905 ms
Total hot run time: 173155 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2024

ClickBench: Total hot run time: 30.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d522c7264304cdc4a03509ffb86c3ef0472431b, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.09
query5	0.50	0.50	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.56	0.49	0.50
query10	0.53	0.56	0.56
query11	0.17	0.12	0.12
query12	0.15	0.12	0.13
query13	0.61	0.59	0.62
query14	0.79	0.79	0.79
query15	0.85	0.86	0.83
query16	0.36	0.37	0.38
query17	0.98	0.95	1.03
query18	0.24	0.22	0.26
query19	1.81	1.72	1.75
query20	0.02	0.01	0.01
query21	15.42	0.67	0.67
query22	4.10	7.22	2.22
query23	18.27	1.41	1.27
query24	2.23	0.22	0.23
query25	0.16	0.09	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.08
query28	13.17	1.02	1.00
query29	12.61	3.35	3.31
query30	0.26	0.07	0.06
query31	2.85	0.39	0.38
query32	3.29	0.48	0.47
query33	2.93	2.90	2.89
query34	17.17	4.42	4.39
query35	4.45	4.49	4.45
query36	0.64	0.46	0.46
query37	0.19	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.41 s
Total hot run time: 30.97 s

dataroaring
dataroaring approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit faa2c17 into apache:master Jun 21, 2024
iszhangpch pushed a commit to iszhangpch/doris-p that referenced this pull request Jun 21, 2024
@Yukang-Lian
[Enhancement](group commit) Use async group commit rpc call (apache#3…
d086c67 
…6499)
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@Yukang-Lian @dataroaring
[Enhancement](group commit) Use async group commit rpc call (#36499)
6090d16
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Jul 7, 2024
@Yukang-Lian
[Enhancement](group commit) Use async group commit rpc call (apache#3…
7373920 
…6499)
@Yukang-Lian Yukang-Lian mentioned this pull request Jul 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 7, 2024
@Yukang-Lian
[cherry-pick](branch-2.1) Pick "Use async group commit rpc call (#36499…
89857d3 
…)" (#37380)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

Pick #36499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyi mymeiyi mymeiyi approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yukang-Lian @doris-robot @mymeiyi @dataroaring