[fix](planner) fix no data issue when use datetimev1/datatimev2 & datev2 as function coalesce's parameter in legacy planner #36583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter in legacy planner
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 50046 ms |
TPC-DS: Total hot run time: 202968 ms |
ClickBench: Total hot run time: 30.65 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Yulei-Yang
changed the title
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49726 ms |
starocean999
approved these changes
Jun 20, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Yulei-Yang
changed the title
TPC-DS: Total hot run time: 202630 ms |
ClickBench: Total hot run time: 30.93 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
This was referenced Jun 21, 2024
morrySnow
pushed a commit
that referenced
this pull request
Jun 25, 2024
…sce & ifnull (#36724) cherry-pick from branch-2.0 #36688, #36640, #36583 How to Reproduce: Issue1: use datetimev1 and datev2 as parameters in function coalesce admin set frontend config ("enable_date_conversion"="false"); admin set frontend config ("disable_datev1"="false"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; return no data, which is wrong. when see the excution plan SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; you can see error predicate: CAST(coalesce(CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: CAST(coalesce(`dt`, '2023-06-01') AS DATETIMEV2(0)) >= '2023-06-01 00:00:00' Issue2: use datetimev2 and datev2 as parameters in function coalesce admin set frontend config ("enable_date_conversion"="true"); admin set frontend config ("disable_datev1"="true"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; return no data, which is wrong when see the excution plan SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; you can see error predicate: CAST(coalesce(CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: coalesce(`dt`, '2023-06-01') >= '2023-06-01 00:00:00' Issue3: extend it to multiple parameters. Steps to reproduce: admin set frontend config ("enable_date_conversion"="false"); admin set frontend config ("disable_datev1"="false"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; error sql: select dt from test_cls where coalesce (dt, dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; explain it and find wrong predicate: CAST(coalesce(CAST(`dt` AS BIGINT), CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: explain it coalesce(CAST(`dt` AS DATETIMEV2(0)), CAST(`dt` AS DATETIMEV2(0)), '2023-06-01 00:00:00') >= '2023-06-01 00:00:00' Issue3: nereids has the same issue with legacy planner
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2024
…sce & ifnull (#36724) cherry-pick from branch-2.0 #36688, #36640, #36583 How to Reproduce: Issue1: use datetimev1 and datev2 as parameters in function coalesce admin set frontend config ("enable_date_conversion"="false"); admin set frontend config ("disable_datev1"="false"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; return no data, which is wrong. when see the excution plan SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; you can see error predicate: CAST(coalesce(CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: CAST(coalesce(`dt`, '2023-06-01') AS DATETIMEV2(0)) >= '2023-06-01 00:00:00' Issue2: use datetimev2 and datev2 as parameters in function coalesce admin set frontend config ("enable_date_conversion"="true"); admin set frontend config ("disable_datev1"="true"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; return no data, which is wrong when see the excution plan SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; you can see error predicate: CAST(coalesce(CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: coalesce(`dt`, '2023-06-01') >= '2023-06-01 00:00:00' Issue3: extend it to multiple parameters. Steps to reproduce: admin set frontend config ("enable_date_conversion"="false"); admin set frontend config ("disable_datev1"="false"); drop table test_cls; CREATE TABLE `test_cls` ( `id` int(11) NOT NULL COMMENT '', `name` varchar(32) NOT NULL COMMENT '', `dt` datetime NOT NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 2 PROPERTIES( "replication_allocation" = "tag.location.default: 1" ); SET enable_nereids_planner=false; error sql: select dt from test_cls where coalesce (dt, dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01'; explain it and find wrong predicate: CAST(coalesce(CAST(`dt` AS BIGINT), CAST(`dt` AS BIGINT), 20230601) AS DOUBLE) >= NULL after fix: explain it coalesce(CAST(`dt` AS DATETIMEV2(0)), CAST(`dt` AS DATETIMEV2(0)), '2023-06-01 00:00:00') >= '2023-06-01 00:00:00' Issue3: nereids has the same issue with legacy planner
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…ev2 as function coalesce's parameter in legacy planner (apache#36583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to Reproduce:
Issue1: use datetimev1 and datev2 as parameters in function coalesce
sql
SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01';return no data, which is wrongwhen see the excution plan
SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01';you can see error predicate:
CAST(coalesce(CAST(
dtAS BIGINT), 20230601) AS DOUBLE) >= NULLafter fix:
CAST(coalesce(
dt, '2023-06-01') AS DATETIMEV2(0)) >= '2023-06-01 00:00:00'Issue2: use datetimev2 and datev2 as parameters in function coalesce
sql
SET enable_nereids_planner=false; select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01';return no data, which is wrongwhen see the excution plan
SET enable_nereids_planner=false; explain select dt from test_cls where coalesce (dt, str_to_date(concat('202306', '01'), '%Y%m%d')) >= '2023-06-01';you can see error predicate:
CAST(coalesce(CAST(
dtAS BIGINT), 20230601) AS DOUBLE) >= NULLafter fix:
coalesce(
dt, '2023-06-01') >= '2023-06-01 00:00:00'