-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](inverted index) fix wrong opt for pk no need read data #36618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
39e67a8 to
e1d3ec4
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40088 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172194 ms |
ClickBench: Total hot run time: 31.12 s |
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The optimization to avoid reading data for primary keys (PK) in segment_iterator can lead to incorrect results when there are function expressions involving the same PK column in the predicate.
…ache#36633) ## Proposed changes Pick from apache#36618
Proposed changes
The optimization to avoid reading data for primary keys (PK) in segment_iterator can lead to incorrect results when there are function expressions involving the same PK column in the predicate.