Skip to content

[Improvement](load) Do no block in group commit sink#36717

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:imp_0624
Jun 24, 2024
Merged

[Improvement](load) Do no block in group commit sink#36717
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:imp_0624

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

@Gabriel39 Gabriel39 commented Jun 24, 2024

Proposed changes

Do not rely on a conditional variable in group commit sink

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 40221 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 15864bdc6de2c18717b0d996d25fbfa98c8e5839, data reload: false

------ Round 1 ----------------------------------
q1	17610	4321	4311	4311
q2	2013	190	207	190
q3	10442	1146	1129	1129
q4	10187	875	750	750
q5	7475	2678	2574	2574
q6	223	135	131	131
q7	956	620	611	611
q8	9217	2073	2055	2055
q9	8851	6507	6503	6503
q10	8877	3687	3708	3687
q11	444	241	234	234
q12	428	238	232	232
q13	18186	2999	2979	2979
q14	270	219	217	217
q15	525	469	498	469
q16	519	380	381	380
q17	973	594	706	594
q18	8002	7394	7280	7280
q19	5518	1443	1402	1402
q20	693	317	336	317
q21	4845	3949	3846	3846
q22	388	336	330	330
Total cold run time: 116642 ms
Total hot run time: 40221 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4434	4225	4264	4225
q2	395	272	276	272
q3	2950	2863	2939	2863
q4	1978	1711	1685	1685
q5	5609	5544	5441	5441
q6	218	131	129	129
q7	2207	1886	1835	1835
q8	3386	3424	3447	3424
q9	8647	8688	8810	8688
q10	4097	3812	3756	3756
q11	612	501	492	492
q12	802	641	624	624
q13	16126	3191	3147	3147
q14	295	279	265	265
q15	532	479	505	479
q16	522	437	447	437
q17	1800	1510	1500	1500
q18	8164	7813	7798	7798
q19	1861	1587	1643	1587
q20	3035	1925	1864	1864
q21	5112	5036	4710	4710
q22	698	589	543	543
Total cold run time: 73480 ms
Total hot run time: 55764 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 172630 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 15864bdc6de2c18717b0d996d25fbfa98c8e5839, data reload: false

query1	924	376	369	369
query2	6454	2360	2337	2337
query3	6636	210	216	210
query4	19051	17170	17405	17170
query5	3551	476	458	458
query6	252	167	166	166
query7	4584	304	295	295
query8	323	288	291	288
query9	8560	2360	2336	2336
query10	568	305	280	280
query11	10575	10056	9951	9951
query12	120	87	87	87
query13	1654	375	365	365
query14	8751	7653	6254	6254
query15	228	192	189	189
query16	7764	269	260	260
query17	1921	539	529	529
query18	1954	264	266	264
query19	189	158	165	158
query20	88	83	85	83
query21	219	129	123	123
query22	4322	4207	4003	4003
query23	33496	33404	33768	33404
query24	11112	2976	2869	2869
query25	614	385	392	385
query26	754	152	159	152
query27	2358	339	334	334
query28	6487	2128	2130	2128
query29	894	615	625	615
query30	261	148	151	148
query31	975	767	785	767
query32	94	65	58	58
query33	759	284	274	274
query34	1064	474	481	474
query35	762	620	612	612
query36	1105	981	987	981
query37	146	71	68	68
query38	2952	2864	2818	2818
query39	914	841	823	823
query40	208	133	130	130
query41	55	62	56	56
query42	111	104	103	103
query43	576	559	561	559
query44	1211	735	751	735
query45	188	165	162	162
query46	1074	744	731	731
query47	1886	1778	1749	1749
query48	418	303	307	303
query49	855	413	404	404
query50	772	395	397	395
query51	6924	6773	6713	6713
query52	113	87	96	87
query53	355	284	283	283
query54	856	446	447	446
query55	73	72	71	71
query56	282	252	263	252
query57	1108	1032	1058	1032
query58	248	257	247	247
query59	3511	3209	3537	3209
query60	308	277	291	277
query61	95	95	95	95
query62	610	436	460	436
query63	310	287	288	287
query64	8659	2231	1727	1727
query65	3180	3087	3098	3087
query66	738	324	330	324
query67	15536	15254	14939	14939
query68	4495	525	538	525
query69	511	390	347	347
query70	1103	1110	1110	1110
query71	409	277	271	271
query72	7617	5451	5520	5451
query73	750	334	337	334
query74	5855	5508	5466	5466
query75	3433	2651	2627	2627
query76	2294	949	902	902
query77	410	295	300	295
query78	10450	9821	9735	9735
query79	2182	514	511	511
query80	1270	468	458	458
query81	584	287	221	221
query82	687	97	100	97
query83	257	166	168	166
query84	239	85	83	83
query85	1642	289	268	268
query86	457	297	338	297
query87	3300	3086	3089	3086
query88	4120	2442	2427	2427
query89	467	377	376	376
query90	1713	185	185	185
query91	129	101	100	100
query92	56	47	48	47
query93	2407	505	506	505
query94	1112	179	177	177
query95	395	316	304	304
query96	582	267	273	267
query97	3180	3035	3072	3035
query98	212	197	204	197
query99	1243	862	836	836
Total cold run time: 267256 ms
Total hot run time: 172630 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 15864bdc6de2c18717b0d996d25fbfa98c8e5839, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.09
query5	0.50	0.48	0.48
query6	1.13	0.74	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.55	0.49	0.48
query10	0.56	0.55	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.59	0.60
query14	0.78	0.80	0.79
query15	0.86	0.81	0.82
query16	0.36	0.37	0.38
query17	1.04	1.03	0.98
query18	0.21	0.24	0.24
query19	1.84	1.72	1.72
query20	0.01	0.01	0.01
query21	15.41	0.66	0.65
query22	4.09	8.20	1.78
query23	18.30	1.34	1.35
query24	2.18	0.23	0.22
query25	0.16	0.08	0.08
query26	0.27	0.18	0.18
query27	0.09	0.08	0.08
query28	13.16	1.03	1.00
query29	12.60	3.35	3.33
query30	0.26	0.07	0.06
query31	2.85	0.39	0.39
query32	3.28	0.47	0.47
query33	2.87	2.82	2.92
query34	17.22	4.39	4.43
query35	4.47	4.42	4.47
query36	0.66	0.46	0.46
query37	0.18	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.04	0.04
query40	0.17	0.14	0.15
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.44 s
Total hot run time: 30.5 s

@Gabriel39 Gabriel39 merged commit 08dedc8 into apache:master Jun 24, 2024
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
Do not rely on a conditional variable in group commit sink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants