[fix](pipeline) fix exception safety issue in MultiCastDataStreamer #36748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40508 ms |
TPC-DS: Total hot run time: 174080 ms |
ClickBench: Total hot run time: 30.33 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 40173 ms |
TPC-DS: Total hot run time: 171432 ms |
ClickBench: Total hot run time: 32.03 s |
mrhhsg
force-pushed
the
fix_multi_streamer
branch
from
4519faf to
9cb10d1
Compare
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40880 ms |
TPC-DS: Total hot run time: 169617 ms |
ClickBench: Total hot run time: 31.32 s |
Gabriel39
approved these changes
Jun 25, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 39952 ms |
TPC-DS: Total hot run time: 171925 ms |
ClickBench: Total hot run time: 31.21 s |
zhangstar333
approved these changes
Jun 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 28, 2024
…36748) ## Proposed changes ```cpp RETURN_IF_ERROR(vectorized::MutableBlock(block).merge(*pos_to_pull->_block)) ``` this line may throw an exception(cannot allocate)
mrhhsg
added a commit
that referenced
this pull request
Jul 15, 2024
…36814) ## Proposed changes pick #36748 ```cpp RETURN_IF_ERROR(vectorized::MutableBlock(block).merge(*pos_to_pull->_block)) ``` this line may throw an exception(cannot allocate) ``` *** Query id: b7b80bfd76cc42a5-a9916f8364d5a4d3 *** *** tablet id: 0 *** *** Aborted at 1719187603 (unix time) try "date -d @1719187603" if you are using GNU date *** *** Current BE git commitID: a8c48f5 *** *** SIGSEGV address not mapped to object (@0x47) received by PID 1197117 (TID 1197376 OR 0x7f49a25e4640) from PID 71; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris_branch-2.0/doris/be/src/common/signal_handler.h:417 1# os::Linux::chained_handler(int, siginfo_t*, void*) in /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo_t*, void*) in /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so 4# 0x00007F4ABB927520 in /lib/x86_64-linux-gnu/libc.so.6 5# std::default_delete<doris::vectorized::Block>::operator()(doris::vectorized::Block*) const at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:85 6# doris::pipeline::MultiCastDataStreamer::close_sender(int) at /root/doris_branch-2.0/doris/be/src/pipeline/exec/multi_cast_data_streamer.cpp:60 7# doris::pipeline::MultiCastDataStreamerSourceOperator::close(doris::RuntimeState*) at /root/doris_branch-2.0/doris/be/src/pipeline/exec/multi_cast_data_stream_source.cpp:120 8# doris::pipeline::PipelineTask::close() at /root/doris_branch-2.0/doris/be/src/pipeline/pipeline_task.cpp:334 9# doris::pipeline::TaskScheduler::_try_close_task(doris::pipeline::PipelineTask*, doris::pipeline::PipelineTaskState) at /root/doris_branch-2.0/doris/be/src/pipeline/task_scheduler.cpp:353 10# doris::pipeline::TaskScheduler::_do_work(unsigned long) in /mnt/disk1/STRESS_ENV/be/lib/doris_be 11# doris::ThreadPool::dispatch_thread() in /mnt/disk1/STRESS_ENV/be/lib/doris_be 12# doris::Thread::supervise_thread(void*) at /root/doris_branch-2.0/doris/be/src/util/thread.cpp:499 13# start_thread at ./nptl/pthread_create.c:442 14# 0x00007F4ABBA0B850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83 ``` <!--Describe your changes.-->
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…pache#36813) ## Proposed changes pick apache#36748 ```cpp RETURN_IF_ERROR(vectorized::MutableBlock(block).merge(*pos_to_pull->_block)) ``` this line may throw an exception(cannot allocate) <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
RETURN_IF_ERROR(vectorized::MutableBlock(block).merge(*pos_to_pull->_block))this line may throw an exception(cannot allocate)