Skip to content

Conversation

@GoGoWen
Copy link
Contributor

@GoGoWen GoGoWen commented Jun 26, 2024

Proposed changes

fix file scanner is still running when the query is timeout/killed. (master branch is fixed)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 50038 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c9cd982263ebfd533a85ba48486be86908d889f, data reload: false

------ Round 1 ----------------------------------
q1	18072	4408	4383	4383
q2	2062	159	147	147
q3	10401	1897	2005	1897
q4	10191	1269	1324	1269
q5	8626	3883	3934	3883
q6	236	125	125	125
q7	2065	1635	1617	1617
q8	9291	2774	2744	2744
q9	10614	10337	10164	10164
q10	8648	3504	3539	3504
q11	430	247	238	238
q12	479	303	305	303
q13	18337	3946	4006	3946
q14	361	326	330	326
q15	504	458	460	458
q16	683	584	584	584
q17	1155	971	997	971
q18	7241	7008	7004	7004
q19	1794	1697	1657	1657
q20	557	323	296	296
q21	4418	4108	4081	4081
q22	543	449	441	441
Total cold run time: 116708 ms
Total hot run time: 50038 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4373	4305	4324	4305
q2	322	228	218	218
q3	4156	4170	4130	4130
q4	2775	2759	2752	2752
q5	7125	7085	7106	7085
q6	238	118	116	116
q7	3226	2835	2767	2767
q8	4317	4422	4443	4422
q9	17044	16893	16813	16813
q10	4223	4243	4264	4243
q11	754	692	687	687
q12	1045	865	881	865
q13	7275	3747	3749	3747
q14	452	432	413	413
q15	513	460	459	459
q16	740	681	675	675
q17	3854	3809	3811	3809
q18	8743	8870	8811	8811
q19	1722	1748	1689	1689
q20	2373	2098	2092	2092
q21	8491	8483	8463	8463
q22	1072	980	993	980
Total cold run time: 84833 ms
Total hot run time: 79541 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203177 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c9cd982263ebfd533a85ba48486be86908d889f, data reload: false

query1	931	431	384	384
query2	6547	2932	2429	2429
query3	6920	201	198	198
query4	21506	18137	17887	17887
query5	19769	6562	6523	6523
query6	289	221	233	221
query7	4157	305	301	301
query8	459	409	415	409
query9	3094	2655	2572	2572
query10	412	295	305	295
query11	11370	10712	10692	10692
query12	126	80	73	73
query13	5614	702	689	689
query14	17660	13706	13512	13512
query15	357	245	242	242
query16	6488	285	269	269
query17	1726	1452	861	861
query18	2348	406	413	406
query19	213	151	153	151
query20	76	76	76	76
query21	189	101	94	94
query22	5239	5044	5142	5044
query23	32707	31851	31998	31851
query24	7032	6562	6470	6470
query25	537	444	424	424
query26	530	161	161	161
query27	1876	292	295	292
query28	6210	2381	2337	2337
query29	2916	2725	2870	2725
query30	241	174	167	167
query31	922	750	745	745
query32	72	67	61	61
query33	403	251	264	251
query34	856	465	472	465
query35	1122	894	940	894
query36	1228	1140	1201	1140
query37	89	62	67	62
query38	3115	2940	2964	2940
query39	1362	1301	1308	1301
query40	211	96	97	96
query41	46	45	44	44
query42	81	94	84	84
query43	723	756	776	756
query44	1144	728	720	720
query45	251	232	235	232
query46	1216	940	996	940
query47	1840	1749	1787	1749
query48	1033	709	694	694
query49	625	369	362	362
query50	867	648	572	572
query51	4733	4651	4633	4633
query52	93	77	82	77
query53	450	330	317	317
query54	2633	2469	2470	2469
query55	92	85	93	85
query56	245	240	229	229
query57	1187	1109	1105	1105
query58	227	197	210	197
query59	4059	3666	3824	3666
query60	225	202	222	202
query61	103	101	99	99
query62	845	445	430	430
query63	484	338	340	338
query64	2588	1523	1500	1500
query65	3686	3563	3575	3563
query66	766	392	376	376
query67	15644	15528	15678	15528
query68	8437	661	651	651
query69	574	346	348	346
query70	1646	1460	1286	1286
query71	419	323	312	312
query72	6563	3483	3548	3483
query73	732	331	319	319
query74	6293	5814	5835	5814
query75	4616	3684	3571	3571
query76	4748	1111	1181	1111
query77	626	253	263	253
query78	12676	11661	11737	11661
query79	7909	665	656	656
query80	1383	411	418	411
query81	504	248	237	237
query82	1472	100	103	100
query83	181	141	139	139
query84	265	72	73	72
query85	1013	324	327	324
query86	341	290	303	290
query87	3243	2959	3024	2959
query88	5287	2332	2352	2332
query89	383	287	294	287
query90	1855	215	215	215
query91	172	153	140	140
query92	61	57	54	54
query93	4949	561	606	561
query94	797	210	213	210
query95	1111	1097	1064	1064
query96	646	324	340	324
query97	6464	6275	6375	6275
query98	201	186	174	174
query99	3052	869	1010	869
Total cold run time: 311424 ms
Total hot run time: 203177 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c9cd982263ebfd533a85ba48486be86908d889f, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.03
query3	0.25	0.05	0.05
query4	1.79	0.06	0.07
query5	0.53	0.53	0.53
query6	1.29	0.63	0.61
query7	0.02	0.01	0.01
query8	0.03	0.03	0.02
query9	0.54	0.49	0.48
query10	0.55	0.54	0.54
query11	0.12	0.08	0.08
query12	0.12	0.08	0.09
query13	0.62	0.61	0.62
query14	0.78	0.77	0.81
query15	0.78	0.76	0.75
query16	0.36	0.35	0.40
query17	0.99	1.00	1.00
query18	0.22	0.25	0.23
query19	1.92	1.84	1.84
query20	0.01	0.01	0.01
query21	15.44	0.54	0.53
query22	2.06	2.23	1.56
query23	17.27	0.96	0.94
query24	4.68	0.65	1.42
query25	0.39	0.14	0.05
query26	0.49	0.16	0.17
query27	0.04	0.04	0.04
query28	8.38	0.71	0.71
query29	12.66	2.28	2.22
query30	0.62	0.53	0.53
query31	2.82	0.39	0.38
query32	3.37	0.50	0.51
query33	3.10	3.10	3.07
query34	15.25	4.78	4.77
query35	4.86	4.82	4.84
query36	1.06	1.02	1.02
query37	0.06	0.05	0.04
query38	0.04	0.02	0.03
query39	0.03	0.01	0.01
query40	0.17	0.14	0.15
query41	0.07	0.01	0.01
query42	0.02	0.01	0.02
query43	0.03	0.01	0.01
Total cold run time: 103.92 s
Total hot run time: 30.26 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (8102/21466)
Line Coverage: 29.38% (66341/225805)
Region Coverage: 28.89% (34232/118483)
Branch Coverage: 24.78% (17590/70978)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9c9cd982263ebfd533a85ba48486be86908d889f_9c9cd982263ebfd533a85ba48486be86908d889f/report/index.html

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9c9cd982263ebfd533a85ba48486be86908d889f with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.5 seconds inserted 10000000 Rows, about 465K ops/s

@xiaokang xiaokang requested a review from HappenLee August 1, 2024 15:20
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

PR approved by anyone and no changes requested.

@xiaokang xiaokang merged commit fdce054 into apache:branch-2.0 Aug 2, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.14-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants