Skip to content

[opt](function) opt function coalesce by spik null column #36953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mryange wants to merge 1 commit into from
Closed

[opt](function) opt function coalesce by spik null column #36953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions be/src/vec/functions/function_coalesce.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,17 +94,21 @@ class FunctionCoalesce : public IFunction {

for (size_t i = 0; i < arguments.size(); ++i) {
const auto& arg_type = block.get_by_position(arguments[i]).type;
filtered_args.push_back(arguments[i]);
if (!arg_type->is_nullable()) {
if (i == 0) {
block.get_by_position(result).column =
block.get_by_position(arguments[0])
.column->clone_resized(input_rows_count);
return Status::OK();
} else {
break;
}
const auto& column = block.get_by_position(arguments[i]).column;
if (!arg_type->is_nullable() && i == 0) {
block.get_by_position(result).column =
block.get_by_position(arguments[0]).column->clone_resized(input_rows_count);
return Status::OK();
}
if (!column->only_null()) {
filtered_args.push_back(arguments[i]);
}
}

if (filtered_args.empty()) {
block.get_by_position(result).column =
block.get_by_position(arguments[0]).column->clone_resized(input_rows_count);
return Status::OK();
}

size_t remaining_rows = input_rows_count;
Expand Down