[fix](hive) support find serde info from both tbl properties and serde properties#37043
Merged
morningman merged 4 commits intoapache:masterfrom Jul 2, 2024
Merged
[fix](hive) support find serde info from both tbl properties and serde properties#37043morningman merged 4 commits intoapache:masterfrom
morningman merged 4 commits intoapache:masterfrom
Conversation
…with 'serialization.format'
Contributor
Author
|
run buildall |
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
TPC-H: Total hot run time: 39654 ms |
TPC-DS: Total hot run time: 173924 ms |
ClickBench: Total hot run time: 30.72 s |
cambyzju
reviewed
Jul 1, 2024
| } | ||
| // For column separator, first find "field.delim", then "serialization.format". | ||
| String columnSeparator = delimiter.getOrDefault(PROP_FIELD_DELIMITER, | ||
| delimiter.getOrDefault(PROP_SERIALIZATION_FORMAT, "")); |
Contributor
There was a problem hiding this comment.
Suggested change
| delimiter.getOrDefault(PROP_SERIALIZATION_FORMAT, "")); | |
| delimiter.getOrDefault(PROP_SERIALIZATION_FORMAT, DEFAULT_FIELD_DELIMITER)); |
Contributor
Author
There was a problem hiding this comment.
Can not give. Because if we dont find PROP_FIELD_DELIMITER and PROP_SERIALIZATION_FORMAT, we should continue find PROP_SEPARATOR_CHAR
cambyzju
previously approved these changes
Jul 1, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
morningman
changed the title
wuwenchi
approved these changes
Jul 2, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42652 ms |
TPC-DS: Total hot run time: 173888 ms |
ClickBench: Total hot run time: 30.8 s |
zy-kkk
approved these changes
Jul 2, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jul 2, 2024
…e properties (apache#37043) Some hive table set serde properties in tblproperties. We need to support it
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jul 4, 2024
…e properties (apache#37043) Some hive table set serde properties in tblproperties. We need to support it
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jul 9, 2024
…e properties (apache#37043) Some hive table set serde properties in tblproperties. We need to support it
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…e properties (#37043) Some hive table set serde properties in tblproperties. We need to support it
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some hive table set serde properties in tblproperties.
We need to support it