Skip to content

[Fix](Variant) fix should not implicit cast to variant#37245

Closed
eldenmoon wants to merge 1 commit into
apache:masterfrom
eldenmoon:var-impl
Closed

[Fix](Variant) fix should not implicit cast to variant#37245
eldenmoon wants to merge 1 commit into
apache:masterfrom
eldenmoon:var-impl

Conversation

@eldenmoon
Copy link
Copy Markdown
Member

query like

SELECT "1234"["abc"]

will be casted to variant implicitly

Proposed changes

Issue Number: close #xxx

query like
```
SELECT "1234"["abc"]
```
will be casted to variant implicitly
@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Copy Markdown
Member Author

run buildall

@eldenmoon eldenmoon closed this Jul 4, 2024
@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 39995 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a433af09384b1a71afa240a431bdb14b6f775fd, data reload: false

------ Round 1 ----------------------------------
q1	17608	4290	4301	4290
q2	2016	195	194	194
q3	10452	1188	1028	1028
q4	10194	785	760	760
q5	7495	2796	2667	2667
q6	230	146	139	139
q7	959	605	618	605
q8	9258	2088	2090	2088
q9	8977	6483	6494	6483
q10	8999	3716	3727	3716
q11	467	244	242	242
q12	513	247	246	246
q13	18272	2985	3041	2985
q14	290	225	217	217
q15	522	485	470	470
q16	502	388	372	372
q17	963	709	707	707
q18	7888	7506	7352	7352
q19	6969	1587	1597	1587
q20	658	348	326	326
q21	4954	3182	3272	3182
q22	393	345	339	339
Total cold run time: 118579 ms
Total hot run time: 39995 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4452	4372	4240	4240
q2	390	270	263	263
q3	2998	2906	2918	2906
q4	2019	1680	1752	1680
q5	5625	5513	5464	5464
q6	219	144	130	130
q7	2243	1841	1843	1841
q8	3259	3417	3430	3417
q9	8710	8743	8748	8743
q10	4090	3783	3790	3783
q11	579	514	515	514
q12	822	653	665	653
q13	17502	3212	3243	3212
q14	311	263	281	263
q15	532	483	489	483
q16	479	420	429	420
q17	1802	1532	1524	1524
q18	8219	7918	7753	7753
q19	1803	1632	1572	1572
q20	2166	1892	1858	1858
q21	9208	4725	4940	4725
q22	635	564	579	564
Total cold run time: 78063 ms
Total hot run time: 56008 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 173030 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a433af09384b1a71afa240a431bdb14b6f775fd, data reload: false

query1	914	374	364	364
query2	6442	2458	2327	2327
query3	6632	201	211	201
query4	20304	17577	17318	17318
query5	3650	513	485	485
query6	255	174	179	174
query7	4593	293	287	287
query8	306	306	283	283
query9	8600	2453	2438	2438
query10	562	283	286	283
query11	10518	10062	10012	10012
query12	113	86	83	83
query13	1632	372	359	359
query14	8456	7534	6595	6595
query15	222	186	191	186
query16	7745	321	304	304
query17	1750	557	516	516
query18	1939	272	270	270
query19	189	145	148	145
query20	89	79	83	79
query21	211	133	130	130
query22	4554	4076	4067	4067
query23	34012	33754	33598	33598
query24	10864	2881	2911	2881
query25	644	406	439	406
query26	1405	159	150	150
query27	3118	327	326	326
query28	7907	2168	2157	2157
query29	941	617	637	617
query30	255	154	157	154
query31	997	786	784	784
query32	95	51	54	51
query33	759	313	285	285
query34	1080	481	478	478
query35	732	636	654	636
query36	1105	978	992	978
query37	160	74	80	74
query38	3004	2886	2834	2834
query39	889	843	823	823
query40	256	137	122	122
query41	53	52	52	52
query42	124	98	102	98
query43	597	535	555	535
query44	1222	725	734	725
query45	192	166	165	165
query46	1075	739	725	725
query47	1862	1781	1757	1757
query48	366	297	303	297
query49	869	409	415	409
query50	768	377	383	377
query51	6852	6704	6822	6704
query52	111	89	99	89
query53	356	284	284	284
query54	867	449	440	440
query55	75	78	75	75
query56	283	271	291	271
query57	1150	1057	1055	1055
query58	252	273	240	240
query59	3230	3197	3194	3194
query60	297	285	287	285
query61	99	88	96	88
query62	615	430	436	430
query63	310	289	282	282
query64	8837	2279	1789	1789
query65	3168	3117	3100	3100
query66	833	333	338	333
query67	15577	14939	14926	14926
query68	5512	544	546	544
query69	621	422	338	338
query70	1089	1143	1166	1143
query71	446	287	280	280
query72	7374	5770	5529	5529
query73	771	326	319	319
query74	5985	5548	5499	5499
query75	3823	2614	2648	2614
query76	3605	957	956	956
query77	616	302	295	295
query78	9542	8892	9102	8892
query79	2642	508	508	508
query80	2244	467	460	460
query81	565	225	219	219
query82	767	113	105	105
query83	281	173	173	173
query84	275	88	84	84
query85	1441	290	288	288
query86	471	304	305	304
query87	3327	3090	3115	3090
query88	4002	2377	2368	2368
query89	489	380	383	380
query90	1867	187	183	183
query91	131	101	101	101
query92	58	49	49	49
query93	3481	521	515	515
query94	1122	212	210	210
query95	413	310	321	310
query96	583	264	264	264
query97	3206	2999	3018	2999
query98	233	212	205	205
query99	1194	821	841	821
Total cold run time: 276115 ms
Total hot run time: 173030 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 31.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a433af09384b1a71afa240a431bdb14b6f775fd, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.10
query5	0.50	0.50	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.55	0.48	0.50
query10	0.54	0.53	0.55
query11	0.14	0.11	0.11
query12	0.15	0.12	0.13
query13	0.60	0.59	0.59
query14	0.77	0.79	0.78
query15	0.87	0.85	0.84
query16	0.36	0.37	0.38
query17	1.01	1.03	1.06
query18	0.24	0.24	0.26
query19	1.83	1.72	1.72
query20	0.01	0.01	0.01
query21	15.43	0.81	0.65
query22	4.24	6.36	2.27
query23	18.25	1.56	1.27
query24	2.18	0.24	0.22
query25	0.15	0.10	0.08
query26	0.26	0.18	0.18
query27	0.08	0.08	0.07
query28	13.24	1.06	1.02
query29	12.60	3.25	3.27
query30	0.26	0.06	0.06
query31	2.88	0.39	0.40
query32	3.25	0.49	0.50
query33	2.89	2.96	2.92
query34	17.21	4.51	4.42
query35	4.47	4.47	4.51
query36	0.67	0.48	0.48
query37	0.19	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.03	0.03
query40	0.18	0.14	0.15
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.61 s
Total hot run time: 31.13 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants