[config](trash) change trash_file_expire_time_sec to 0 #37648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
gavinchou
approved these changes
Jul 11, 2024
TPC-H: Total hot run time: 39941 ms |
TPC-DS: Total hot run time: 174509 ms |
ClickBench: Total hot run time: 30.65 s |
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
long time ago, doris may lost data due to program bug: 1) during migrate or clone, may cause new replica lost data; 2) a tablet may delete all its replicas. But all these bugs had been solved. Now trash is useless. There's hardly no user use trash to restore data for prod env. Even a user can use a http to restore data from trash, it still cann't use immedidately because fe not contains its meta. On the other hand, trash has cause other problems: 1) make unbalance because not deleleted the trash data; 2) be chose disks not RR because the disks may suddently delete a lot trash data when disk's usage over 80%; 3) had more disk load. Considering all this, we make trash_file_expire_time_sec change to 0. If user really want to keep trash, they need to set trash_file_expire_time_sec > 0 manually.
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
long time ago, doris may lost data due to program bug: 1) during migrate or clone, may cause new replica lost data; 2) a tablet may delete all its replicas. But all these bugs had been solved. Now trash is useless. There's hardly no user use trash to restore data for prod env. Even a user can use a http to restore data from trash, it still cann't use immedidately because fe not contains its meta. On the other hand, trash has cause other problems: 1) make unbalance because not deleleted the trash data; 2) be chose disks not RR because the disks may suddently delete a lot trash data when disk's usage over 80%; 3) had more disk load. Considering all this, we make trash_file_expire_time_sec change to 0. If user really want to keep trash, they need to set trash_file_expire_time_sec > 0 manually.
Closed
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Dec 25, 2024
long time ago, doris may lost data due to program bug: 1) during migrate or clone, may cause new replica lost data; 2) a tablet may delete all its replicas. But all these bugs had been solved. Now trash is useless. There's hardly no user use trash to restore data for prod env. Even a user can use a http to restore data from trash, it still cann't use immedidately because fe not contains its meta. On the other hand, trash has cause other problems: 1) make unbalance because not deleleted the trash data; 2) be chose disks not RR because the disks may suddently delete a lot trash data when disk's usage over 80%; 3) had more disk load. Considering all this, we make trash_file_expire_time_sec change to 0. If user really want to keep trash, they need to set trash_file_expire_time_sec > 0 manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long time ago, doris may lost data due to program bug:
But all these bugs had been solved. Now trash is useless. There's hardly no user use trash to restore data for prod env. Even a user can use a http to restore data from trash, it still cann't use immedidately because fe not contains its meta.
On the other hand, trash has cause other problems:
Considering all this, we make trash_file_expire_time_sec change to 0. If user really want to keep trash, they need to set trash_file_expire_time_sec > 0 manually.