Skip to content

[opt](nereids) adjust broadcast/shuffle join #37771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
englefly wants to merge 5 commits into from
Closed

[opt](nereids) adjust broadcast/shuffle join #37771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
471655a
adjust broadcast/shuffle join
englefly Jul 8, 2024
5a44a39
shuffle cpu cost
englefly Jul 11, 2024
c19b20f
lower shuffle cup/mem cost
englefly Jul 11, 2024
5594392
v3:better for 6be
englefly Jul 12, 2024
d091199
v4: unify dataSizeFactor for shuffle and bc, 0.05'
englefly Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
import org.apache.doris.nereids.properties.DistributionSpecHash;
import org.apache.doris.nereids.properties.DistributionSpecReplicated;
import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
import org.apache.doris.nereids.trees.expressions.ExprId;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.Slot;
import org.apache.doris.nereids.trees.expressions.SlotReference;
import org.apache.doris.nereids.trees.expressions.literal.Literal;
import org.apache.doris.nereids.trees.plans.Plan;
Expand Down Expand Up @@ -60,6 +62,7 @@
import com.google.common.base.Preconditions;
import com.google.common.collect.Sets;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Set;
Expand Down Expand Up @@ -273,10 +276,11 @@ public Cost visitPhysicalDistribute(
// shuffle
if (spec instanceof DistributionSpecHash) {
return CostV1.of(context.getSessionVariable(),
0,
intputRowCount / beNumber,
0,
intputRowCount * childStatistics.dataSizeFactor(
distribute.child().getOutput()) / beNumber);
distribute.child().getOutput()) / beNumber
);
}

// replicate
Expand Down
4 changes: 1 addition & 3 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/Statistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@ public double computeSize(List<Slot> slots) {
}

public double dataSizeFactor(List<Slot> slots) {
double lowerBound = 0.03;
double upperBound = 0.07;
return Math.min(Math.max(computeTupleSize(slots) / K_BYTES, lowerBound), upperBound);
return 0.05 * computeTupleSize(slots);
}

@Override
Expand Down