-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](Azure) Make azure dependency compile one config #38239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](Azure) Make azure dependency compile one config #38239
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include <fmt/core.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'fmt/core.h' file not found [clang-diagnostic-error]
#include <fmt/core.h>
^
|
|
|
|
|
run buildall |
TPC-H: Total hot run time: 40003 ms |
TPC-DS: Total hot run time: 171959 ms |
ClickBench: Total hot run time: 30.58 s |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
|
||
| #pragma once | ||
|
|
||
| #include <aws/core/client/AWSError.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'aws/core/client/AWSError.h' file not found [clang-diagnostic-error]
#include <aws/core/client/AWSError.h>
^|
run buildall |
TPC-H: Total hot run time: 39696 ms |
TPC-DS: Total hot run time: 174169 ms |
ClickBench: Total hot run time: 30.64 s |
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. tested on arm fine.
|
PR approved by anyone and no changes requested. |
|
run arm |
|
PR approved by at least one committer and no changes requested. |
Previously the azure sdk would be compiled into BE by default. But sometimes the BE would run in environment which only require AWS s3-compatible functionality. So user can use `DISABLE_BUILD_AZURE` to control whether build azure sdk into BE or not. `export DISABLE_BUILD_AZURE=ON` to disable build with azure support
Previously the azure sdk would be compiled into BE by default. But sometimes the BE would run in environment which only require AWS s3-compatible functionality. So user can use
DISABLE_BUILD_AZUREto control whether build azure sdk into BE or not.export DISABLE_BUILD_AZURE=ONto disable build with azure support