Skip to content

[cherry-pick](branch-21) fix collect_set function core dump without arena pool (#38234) #38307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 3 commits into from
Jul 25, 2024
Merged

[cherry-pick](branch-21) fix collect_set function core dump without arena pool (#38234) #38307

yiguolei merged 3 commits into from
Jul 25, 2024

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jul 24, 2024

Proposed changes

cherry-pick from master #38234

zhangstar333 and others added 2 commits July 24, 2024 17:36
@zhangstar333
[Bug](agg) fix collect_set function core dump without arena pool (apa…
15d9adc 
…che#38234)

before the add_range_single_place pass nullptr as arena object,
but collect_set function need save data in arena, so will core dump
without arena pool.
@zhangstar333
pipeline code
4fcb761
@doris-robot
Copy link

doris-robot commented Jul 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jul 24, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 24, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (9238/25345)
Line Coverage: 27.98% (75518/269858)
Region Coverage: 26.81% (38832/144856)
Branch Coverage: 23.55% (19717/83734)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4fcb76188cb395e7633487019b42f2c6bfde1b17_4fcb76188cb395e7633487019b42f2c6bfde1b17/report/index.html

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jul 24, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 24, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (9237/25345)
Line Coverage: 27.98% (75510/269858)
Region Coverage: 26.80% (38822/144856)
Branch Coverage: 23.54% (19712/83734)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14028f4ed5d8a1897e9e10b3ca6e98579b9babaa_14028f4ed5d8a1897e9e10b3ca6e98579b9babaa/report/index.html

@yiguolei yiguolei merged commit 57864e8 into apache:branch-2.1 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333 @doris-robot @yiguolei