[fix](cloud) Fix insert_group_commit_into in cloud mode #38471

mymeiyi · 2024-07-29T07:51:00Z

The insert_group_commit_into is failed because:

2024-07-29 13:26:53,212 WARN (mysql-nio-pool-37|242) execute Exception. stmt[117782, b23c0447050d40a8-82c73eb0ba031977]
java.util.UnknownFormatConversionException: Conversion = 'F'
        at java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2855) ~[?:?]
        at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2891) ~[?:?]
        at java.util.Formatter.parse(Formatter.java:2747) ~[?:?]
        at java.util.Formatter.format(Formatter.java:2671) ~[?:?]
        at java.util.Formatter.format(Formatter.java:2625) ~[?:?]
        at java.lang.String.format(String.java:4145) ~[?:?]
        at org.apache.doris.common.ErrorReport.reportCommon(ErrorReport.java:30) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.common.ErrorReport.reportDdlException(ErrorReport.java:68) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.handleInsertStmt(StmtExecutor.java:2397) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:1043) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:646) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.queryRetry(StmtExecutor.java:567) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:557) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:385) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:237) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:260) ~[doris-fe.jar:1.2-SNAPSHOT]

Because the cloud error url may contain %

doris-robot · 2024-07-29T07:51:05Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

mymeiyi · 2024-07-29T07:52:12Z

run buildall

mymeiyi · 2024-07-29T07:57:12Z

run buildall

doris-robot · 2024-07-29T08:15:46Z

TPC-H: Total hot run time: 41596 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38ed10732f7d57d7c607e36afd3ef571a7f071e3, data reload: false

------ Round 1 ----------------------------------
q1	19411	4192	4137	4137
q2	2411	225	221	221
q3	11931	1356	1373	1356
q4	10809	807	925	807
q5	8009	2981	2954	2954
q6	222	140	139	139
q7	1151	642	612	612
q8	9445	1786	1955	1786
q9	8481	6557	6622	6557
q10	8707	3841	3813	3813
q11	432	254	259	254
q12	424	229	235	229
q13	17772	2978	2969	2969
q14	268	239	242	239
q15	537	485	482	482
q16	535	381	391	381
q17	965	912	880	880
q18	7933	7300	7249	7249
q19	1456	1223	1228	1223
q20	574	335	327	327
q21	5397	4750	4699	4699
q22	348	282	283	282
Total cold run time: 117218 ms
Total hot run time: 41596 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4069	4021	3993	3993
q2	326	227	220	220
q3	2983	3007	2980	2980
q4	1874	1840	1865	1840
q5	5246	5222	5205	5205
q6	218	134	136	134
q7	2051	1696	1701	1696
q8	3238	3251	3304	3251
q9	8275	8243	8306	8243
q10	3743	3830	3832	3830
q11	555	466	463	463
q12	731	550	562	550
q13	16469	2917	2924	2917
q14	291	256	261	256
q15	514	480	490	480
q16	447	394	399	394
q17	1711	1692	1700	1692
q18	7662	7353	7251	7251
q19	1678	1697	1681	1681
q20	1987	1743	1758	1743
q21	5459	5196	5140	5140
q22	532	468	470	468
Total cold run time: 70059 ms
Total hot run time: 54427 ms

doris-robot · 2024-07-29T08:26:23Z

TPC-DS: Total hot run time: 168760 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38ed10732f7d57d7c607e36afd3ef571a7f071e3, data reload: false

query1	910	368	367	367
query2	6486	1735	1744	1735
query3	6662	212	219	212
query4	19197	17585	17262	17262
query5	4276	511	543	511
query6	299	167	170	167
query7	4601	308	286	286
query8	250	189	195	189
query9	8491	2388	2374	2374
query10	436	284	262	262
query11	10466	9881	10094	9881
query12	128	86	84	84
query13	1618	377	371	371
query14	8857	7053	8001	7053
query15	217	159	162	159
query16	7092	463	453	453
query17	950	563	538	538
query18	1912	278	277	277
query19	197	145	149	145
query20	92	87	86	86
query21	200	119	97	97
query22	4271	4039	4057	4039
query23	33476	33036	32951	32951
query24	10250	3086	2999	2999
query25	697	393	412	393
query26	1795	153	149	149
query27	3065	274	276	274
query28	7053	1973	1962	1962
query29	1294	418	407	407
query30	290	147	147	147
query31	921	727	764	727
query32	99	57	53	53
query33	696	317	317	317
query34	928	472	486	472
query35	864	738	739	738
query36	1012	856	843	843
query37	206	82	81	81
query38	2854	2777	2791	2777
query39	886	811	808	808
query40	289	119	114	114
query41	52	46	44	44
query42	131	108	104	104
query43	475	422	437	422
query44	1194	723	714	714
query45	224	183	180	180
query46	1081	818	797	797
query47	1789	1705	1711	1705
query48	370	297	299	297
query49	1173	460	458	458
query50	912	440	439	439
query51	6803	6574	6670	6574
query52	106	93	98	93
query53	253	181	174	174
query54	641	457	447	447
query55	77	82	73	73
query56	274	253	255	253
query57	1161	1057	1035	1035
query58	270	271	261	261
query59	2701	2446	2339	2339
query60	304	273	283	273
query61	99	105	100	100
query62	930	656	668	656
query63	218	182	184	182
query64	5936	1913	1878	1878
query65	3142	3096	3077	3077
query66	1459	333	336	333
query67	15236	14781	14878	14781
query68	4409	562	577	562
query69	439	297	294	294
query70	1067	1048	1094	1048
query71	359	273	269	269
query72	7222	2721	2523	2523
query73	762	327	329	327
query74	6104	5680	5683	5680
query75	3379	2704	2743	2704
query76	2303	1349	1387	1349
query77	449	318	303	303
query78	9499	9022	8834	8834
query79	1698	554	535	535
query80	1208	512	507	507
query81	545	220	221	220
query82	1068	129	130	129
query83	237	173	170	170
query84	276	80	78	78
query85	1310	329	309	309
query86	378	292	297	292
query87	3272	3094	3118	3094
query88	2959	2485	2494	2485
query89	391	288	284	284
query90	1773	189	189	189
query91	143	113	120	113
query92	63	52	53	52
query93	1473	622	629	622
query94	900	316	301	301
query95	395	279	279	279
query96	596	282	288	282
query97	3198	2980	3021	2980
query98	225	203	198	198
query99	1617	1299	1319	1299
Total cold run time: 261011 ms
Total hot run time: 168760 ms

doris-robot · 2024-07-29T08:31:51Z

ClickBench: Total hot run time: 29.99 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 38ed10732f7d57d7c607e36afd3ef571a7f071e3, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.04	0.05
query4	1.68	0.07	0.05
query5	0.48	0.49	0.47
query6	1.13	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.56	0.50	0.51
query10	0.56	0.54	0.55
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	0.77	0.78	0.79
query15	0.91	0.85	0.87
query16	0.36	0.36	0.35
query17	0.96	1.00	1.01
query18	0.23	0.21	0.21
query19	1.83	1.69	1.74
query20	0.01	0.01	0.01
query21	15.39	0.77	0.67
query22	4.05	7.26	1.43
query23	17.98	1.32	1.30
query24	2.28	0.22	0.22
query25	0.18	0.10	0.09
query26	0.31	0.22	0.21
query27	0.46	0.24	0.23
query28	13.18	1.00	0.96
query29	12.61	3.36	3.31
query30	0.25	0.06	0.06
query31	2.89	0.40	0.40
query32	3.24	0.50	0.48
query33	2.87	2.94	2.93
query34	15.82	4.27	4.24
query35	4.28	4.27	4.32
query36	0.67	0.47	0.48
query37	0.20	0.16	0.15
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.16	0.13	0.13
query41	0.10	0.04	0.05
query42	0.04	0.04	0.05
query43	0.05	0.04	0.03
Total cold run time: 108.01 s
Total hot run time: 29.99 s

dataroaring

LGTM

github-actions · 2024-07-29T08:35:37Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-07-29T08:35:39Z

PR approved by anyone and no changes requested.

mymeiyi · 2024-07-29T10:41:25Z

run fe_ut

The insert_group_commit_into is failed because: ``` 2024-07-29 13:26:53,212 WARN (mysql-nio-pool-37|242) execute Exception. stmt[117782, b23c0447050d40a8-82c73eb0ba031977] java.util.UnknownFormatConversionException: Conversion = 'F' at java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2855) ~[?:?] at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2891) ~[?:?] at java.util.Formatter.parse(Formatter.java:2747) ~[?:?] at java.util.Formatter.format(Formatter.java:2671) ~[?:?] at java.util.Formatter.format(Formatter.java:2625) ~[?:?] at java.lang.String.format(String.java:4145) ~[?:?] at org.apache.doris.common.ErrorReport.reportCommon(ErrorReport.java:30) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.ErrorReport.reportDdlException(ErrorReport.java:68) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.handleInsertStmt(StmtExecutor.java:2397) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:1043) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:646) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.queryRetry(StmtExecutor.java:567) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:557) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:385) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:237) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:260) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Because the cloud error url may contain `%`

[fix](cloud) Fix insert_group_commit_into in cloud mode

0c1bddc

fix

38ed107

dataroaring approved these changes Jul 29, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 29, 2024

github-actions bot added the reviewed label Jul 29, 2024

Yukang-Lian approved these changes Jul 29, 2024

View reviewed changes

dataroaring merged commit 790a13c into apache:master Jul 29, 2024

dataroaring added the dev/3.0.1-merged label Aug 11, 2024

gavinchou mentioned this pull request Aug 19, 2024

Release Note 3.0.1 #39570

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix](cloud) Fix insert_group_commit_into in cloud mode #38471

[fix](cloud) Fix insert_group_commit_into in cloud mode #38471

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

dataroaring left a comment

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[fix](cloud) Fix insert_group_commit_into in cloud mode #38471

[fix](cloud) Fix insert_group_commit_into in cloud mode #38471

Uh oh!

Conversation

mymeiyi commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

mymeiyi commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants