[fix](memory) Fix Allocator release memory to correct MemTracker after TLS attach task ends #38959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xinyiZzz
force-pushed
the
20240806_fix_allocator
branch
from
c5fb74c to
67c7e0a
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42265 ms |
TPC-DS: Total hot run time: 168755 ms |
ClickBench: Total hot run time: 31.33 s |
xinyiZzz
force-pushed
the
20240806_fix_allocator
branch
from
a9624e1 to
a68a94d
Compare
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42037 ms |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42107 ms |
TPC-DS: Total hot run time: 168545 ms |
yiguolei
reviewed
Aug 7, 2024
be/src/vec/common/allocator.h
Outdated
| class Allocator { | ||
| public: | ||
| Allocator(); | ||
| Allocator(const Allocator& that) { tracker = that.tracker; } |
Contributor
Author
There was a problem hiding this comment.
fixed，目前应该没用，删了跑下流水线看看
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42380 ms |
TPC-DS: Total hot run time: 170335 ms |
ClickBench: Total hot run time: 33.32 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39490 ms |
TPC-H: Total hot run time: 39563 ms |
xinyiZzz
force-pushed
the
20240806_fix_allocator
branch
from
cd3d6d9 to
1eae1e8
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40235 ms |
TPC-H: Total hot run time: 39932 ms |
TPC-DS: Total hot run time: 202429 ms |
ClickBench: Total hot run time: 33.98 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40128 ms |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocator save TLS MemTracker during first alloc, which is used to release memory after TLS attach task ends.