Skip to content

[asancore](memory) release _merge_controller_handler to make sure memtracker is 0#39002

Merged
yiguolei merged 1 commit intoapache:masterfrom
yiguolei:fixrf
Aug 7, 2024
Merged

[asancore](memory) release _merge_controller_handler to make sure memtracker is 0#39002
yiguolei merged 1 commit intoapache:masterfrom
yiguolei:fixrf

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Aug 7, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

yiguolei commented Aug 7, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

yiguolei commented Aug 7, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41554 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 918437f0ef15554b0edb63ab180474316b96eff3, data reload: false

------ Round 1 ----------------------------------
q1	17767	4083	4080	4080
q2	2026	199	196	196
q3	10457	1350	1298	1298
q4	10166	797	902	797
q5	7658	2913	2953	2913
q6	222	142	141	141
q7	1065	623	622	622
q8	9468	1915	1936	1915
q9	8457	6559	6564	6559
q10	8743	3837	3831	3831
q11	431	247	237	237
q12	431	228	228	228
q13	17770	2953	2939	2939
q14	265	242	243	242
q15	514	479	502	479
q16	523	393	400	393
q17	958	923	910	910
q18	7979	7285	7239	7239
q19	2164	1162	1213	1162
q20	555	319	330	319
q21	5260	4777	4770	4770
q22	353	284	284	284
Total cold run time: 113232 ms
Total hot run time: 41554 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4061	4001	4042	4001
q2	331	232	224	224
q3	3012	3002	3151	3002
q4	1959	2021	1958	1958
q5	5580	5528	5489	5489
q6	218	134	132	132
q7	2112	1790	1827	1790
q8	3283	3362	3307	3307
q9	8700	8659	8804	8659
q10	3955	4070	3864	3864
q11	553	458	459	458
q12	792	638	612	612
q13	16488	3095	3111	3095
q14	298	301	280	280
q15	519	485	477	477
q16	462	421	424	421
q17	1769	1734	1746	1734
q18	8278	7693	7754	7693
q19	1719	1684	1713	1684
q20	2084	1825	1819	1819
q21	5720	5549	5305	5305
q22	516	449	467	449
Total cold run time: 72409 ms
Total hot run time: 56453 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169223 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 918437f0ef15554b0edb63ab180474316b96eff3, data reload: false

query1	921	377	374	374
query2	6464	1754	1675	1675
query3	6675	214	229	214
query4	19087	17428	17438	17428
query5	3660	524	525	524
query6	276	174	173	173
query7	4594	303	287	287
query8	272	203	195	195
query9	8511	2316	2304	2304
query10	418	280	266	266
query11	10560	10243	10017	10017
query12	120	88	94	88
query13	1615	369	365	365
query14	8471	7600	6685	6685
query15	226	163	168	163
query16	6971	423	441	423
query17	932	549	541	541
query18	1911	282	277	277
query19	198	138	140	138
query20	93	86	85	85
query21	202	98	98	98
query22	4134	3958	3965	3958
query23	33737	33454	33704	33454
query24	9205	3154	3094	3094
query25	687	408	410	408
query26	1430	158	154	154
query27	3058	282	293	282
query28	7548	1991	1978	1978
query29	1035	444	442	442
query30	242	156	159	156
query31	953	753	761	753
query32	102	56	57	56
query33	673	353	332	332
query34	927	494	522	494
query35	895	757	776	757
query36	1056	895	923	895
query37	221	83	79	79
query38	2947	2911	2822	2822
query39	877	806	827	806
query40	255	112	111	111
query41	48	46	43	43
query42	128	102	105	102
query43	480	444	414	414
query44	1172	717	726	717
query45	213	178	177	177
query46	1102	823	792	792
query47	1820	1700	1722	1700
query48	362	296	296	296
query49	858	428	423	423
query50	890	433	443	433
query51	6920	6742	6594	6594
query52	109	87	88	87
query53	256	182	182	182
query54	636	459	476	459
query55	81	78	76	76
query56	267	264	264	264
query57	1119	1045	1083	1045
query58	260	275	276	275
query59	2632	2304	2650	2304
query60	311	289	288	288
query61	98	93	93	93
query62	896	689	664	664
query63	223	189	194	189
query64	5384	1908	1874	1874
query65	3166	3081	3094	3081
query66	1013	343	345	343
query67	15131	14843	14809	14809
query68	4306	561	569	561
query69	442	304	313	304
query70	1067	1062	1075	1062
query71	361	286	287	286
query72	7164	2651	2501	2501
query73	764	327	333	327
query74	6022	5648	5769	5648
query75	3372	2721	2748	2721
query76	2180	1223	1288	1223
query77	422	316	313	313
query78	9435	8881	8915	8881
query79	1535	526	519	519
query80	1089	493	493	493
query81	556	230	230	230
query82	990	145	130	130
query83	250	173	170	170
query84	269	79	78	78
query85	1227	329	333	329
query86	404	290	309	290
query87	3268	3097	3107	3097
query88	2945	2404	2475	2404
query89	394	293	285	285
query90	1675	199	197	197
query91	127	103	100	100
query92	57	49	49	49
query93	1345	617	613	613
query94	770	304	281	281
query95	387	265	268	265
query96	608	280	278	278
query97	3202	3044	3069	3044
query98	220	211	197	197
query99	1632	1272	1290	1272
Total cold run time: 256219 ms
Total hot run time: 169223 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 918437f0ef15554b0edb63ab180474316b96eff3, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.03
query3	0.23	0.05	0.04
query4	1.67	0.07	0.06
query5	0.49	0.48	0.47
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.57	0.53	0.50
query10	0.56	0.57	0.56
query11	0.16	0.11	0.12
query12	0.16	0.13	0.12
query13	0.61	0.62	0.59
query14	0.77	0.80	0.80
query15	0.90	0.87	0.87
query16	0.35	0.36	0.36
query17	1.00	0.98	1.01
query18	0.22	0.21	0.22
query19	1.84	1.72	1.75
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	4.01	7.66	1.44
query23	18.17	1.41	1.32
query24	2.34	0.22	0.23
query25	0.19	0.08	0.08
query26	0.32	0.21	0.22
query27	0.46	0.23	0.24
query28	13.17	1.01	0.98
query29	12.53	3.29	3.29
query30	0.25	0.06	0.05
query31	2.86	0.41	0.41
query32	3.22	0.50	0.48
query33	2.94	3.05	2.97
query34	15.45	4.25	4.24
query35	4.32	4.30	4.30
query36	0.68	0.48	0.49
query37	0.19	0.17	0.16
query38	0.16	0.15	0.16
query39	0.04	0.04	0.04
query40	0.17	0.13	0.13
query41	0.11	0.05	0.05
query42	0.06	0.06	0.04
query43	0.05	0.03	0.04
Total cold run time: 107.96 s
Total hot run time: 30.2 s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@yiguolei yiguolei merged commit 9d35629 into apache:master Aug 7, 2024
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
…tracker is 0 (#39002)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

Co-authored-by: yiguolei <yiguolei@gmail.com>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
…tracker is 0 (apache#39002)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

Co-authored-by: yiguolei <yiguolei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.1-merged doing p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants