[Improvement](runtime-filter) do not use bloom to replace in_or_bloom when rf need merge #39147
+22
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
englefly
approved these changes
Aug 12, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Aug 13, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
… when rf need merge (apache#39147) ## Proposed changes do not use bloom to replace in_or_bloom when rf need merge Because in some cases, this will lead to poor performance <img width="298" alt="图片" src="https://github.com/user-attachments/assets/bcee330f-bb38-4e51-af76-1a181bd205f9"> <img width="298" alt="图片" src="https://github.com/user-attachments/assets/481a4b06-929d-4f4a-8d10-bf2901e68fdf">
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
… when rf need merge (#39147) ## Proposed changes do not use bloom to replace in_or_bloom when rf need merge Because in some cases, this will lead to poor performance <img width="298" alt="图片" src="https://github.com/user-attachments/assets/bcee330f-bb38-4e51-af76-1a181bd205f9"> <img width="298" alt="图片" src="https://github.com/user-attachments/assets/481a4b06-929d-4f4a-8d10-bf2901e68fdf">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
do not use bloom to replace in_or_bloom when rf need merge
Because in some cases, this will lead to poor performance