[fix](function)timediff with now function causes a error signature (…#39347
Merged
HappenLee merged 2 commits intoapache:branch-2.0from Aug 23, 2024
Merged
[fix](function)timediff with now function causes a error signature (…#39347HappenLee merged 2 commits intoapache:branch-2.0from
HappenLee merged 2 commits intoapache:branch-2.0from
Conversation
…pache#39322) ``` mysql [(none)]>select round(timediff(now(),'2024-08-15')/60/60,2); ERROR 1105 (HY000): errCode = 2, detailMessage = argument 1 requires datetimev2 type, however 'now()' is of datetime type ``` The reason is that the function parameter types were modified in expectedInputTypes, which led to no match being found. The code here is from a long time ago. Because the precision of datetimev2 could not be deduced in the past, a separate implementation was made here. This code can be safely deleted. <!--Describe your changes.-->
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49586 ms |
TPC-DS: Total hot run time: 204700 ms |
ClickBench: Total hot run time: 30.96 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49980 ms |
TPC-DS: Total hot run time: 202851 ms |
ClickBench: Total hot run time: 31.09 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#39322)
#39322
The derivation of precision for the datetime constant in version 2.0 is incorrect, it tends to be derived as the maximum precision.
The reason is that the function parameter types were modified in expectedInputTypes, which led to no match being found. The code here is from a long time ago. Because the precision of datetimev2 could not be deduced in the past, a separate implementation was made here. This code can be safely deleted.
Proposed changes
Issue Number: close #xxx