Skip to content

[fix](protocol) CLIENT_MULTI_STATEMENTS not used actually (#39308)#39371

Merged
xy720 merged 1 commit intoapache:branch-2.0from
cambyzju:fix-2.0-0814
Aug 15, 2024
Merged

[fix](protocol) CLIENT_MULTI_STATEMENTS not used actually (#39308)#39371
xy720 merged 1 commit intoapache:branch-2.0from
cambyzju:fix-2.0-0814

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Aug 14, 2024

pick #39308 to branch-2.0

@cambyzju
[fix](protocol) CLIENT_MULTI_STATEMENTS not used actually (apache#39308)
f14145f 
in pr apache#6759, we try to output
result depend CLIENT_MULTI_STATEMENTS,

but in `MysqlProto::negotiate` function, we call
`context.setCapability(context.getServerCapability())` function set
capability in context use server default flags instead of client flags.

So here, we save CLIENT_MULTI_STATEMENTS flag in MysqlChannel like flag
CLIENT_DEPRECATE_EOF
@doris-robot
Copy link

doris-robot commented Aug 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

cambyzju commented Aug 14, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Aug 14, 2024

TPC-H: Total hot run time: 49606 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f14145f60396239ce6079d6a25fff66f87e8a425, data reload: false

------ Round 1 ----------------------------------
q1	17688	4418	4304	4304
q2	2075	158	148	148
q3	10556	1899	1944	1899
q4	10337	1231	1302	1231
q5	8436	3939	3943	3939
q6	236	124	127	124
q7	2063	1601	1599	1599
q8	9548	2726	2719	2719
q9	13649	10337	10253	10253
q10	8675	3493	3498	3493
q11	399	243	243	243
q12	469	296	300	296
q13	18375	3968	4001	3968
q14	346	337	331	331
q15	510	452	474	452
q16	669	571	573	571
q17	1120	940	878	878
q18	7334	6899	6806	6806
q19	1712	1578	1533	1533
q20	560	317	307	307
q21	4430	4123	4110	4110
q22	500	402	405	402
Total cold run time: 119687 ms
Total hot run time: 49606 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4337	4273	4321	4273
q2	318	226	231	226
q3	4184	4138	4154	4138
q4	2767	2754	2758	2754
q5	7177	7133	7107	7107
q6	241	121	124	121
q7	3321	2832	2844	2832
q8	4394	4475	4475	4475
q9	16918	16698	16648	16648
q10	4204	4286	4251	4251
q11	764	675	678	675
q12	1028	867	873	867
q13	6918	3749	3745	3745
q14	463	421	429	421
q15	503	458	455	455
q16	731	681	680	680
q17	3866	3869	3898	3869
q18	8895	8822	8843	8822
q19	1707	1666	1679	1666
q20	2334	2148	2104	2104
q21	8522	8523	8538	8523
q22	1047	921	975	921
Total cold run time: 84639 ms
Total hot run time: 79573 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2024

TPC-DS: Total hot run time: 201768 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f14145f60396239ce6079d6a25fff66f87e8a425, data reload: false

query1	933	391	403	391
query2	6528	2191	2125	2125
query3	6924	207	201	201
query4	20775	18099	17926	17926
query5	19747	6535	6504	6504
query6	375	222	243	222
query7	4840	292	297	292
query8	265	250	241	241
query9	3121	2713	2646	2646
query10	410	297	293	293
query11	11449	10759	10774	10759
query12	136	76	75	75
query13	5607	658	657	657
query14	18703	13222	13648	13222
query15	360	219	232	219
query16	6446	297	262	262
query17	1616	1458	870	870
query18	2320	429	409	409
query19	211	145	150	145
query20	79	81	81	81
query21	192	97	95	95
query22	5056	5021	4998	4998
query23	32344	31872	31653	31653
query24	6699	6506	6516	6506
query25	546	443	439	439
query26	534	163	160	160
query27	1830	295	295	295
query28	6130	2317	2292	2292
query29	2918	2763	2810	2763
query30	237	168	171	168
query31	902	719	742	719
query32	67	63	56	56
query33	411	271	251	251
query34	852	478	479	478
query35	1090	934	942	934
query36	1399	1258	1241	1241
query37	92	61	62	61
query38	3055	2917	2950	2917
query39	1359	1334	1324	1324
query40	201	96	98	96
query41	41	37	36	36
query42	94	92	78	78
query43	646	615	573	573
query44	1131	718	713	713
query45	248	228	239	228
query46	1238	957	993	957
query47	1796	1708	1712	1708
query48	975	676	656	656
query49	618	376	370	370
query50	852	616	610	610
query51	4782	4620	4608	4608
query52	94	85	75	75
query53	445	318	323	318
query54	2690	2443	2472	2443
query55	92	83	82	82
query56	241	233	225	225
query57	1263	1074	1160	1074
query58	222	201	191	191
query59	3425	3481	3322	3322
query60	223	230	211	211
query61	100	95	100	95
query62	848	474	431	431
query63	499	343	339	339
query64	2636	1532	1458	1458
query65	3632	3556	3557	3556
query66	827	372	393	372
query67	15531	15439	14943	14943
query68	10558	659	652	652
query69	580	354	352	352
query70	2153	1525	1537	1525
query71	410	306	327	306
query72	6565	3547	3539	3539
query73	742	323	332	323
query74	6286	5884	5827	5827
query75	5613	3784	3682	3682
query76	6977	1193	1219	1193
query77	1180	262	266	262
query78	12644	11770	11724	11724
query79	7862	652	655	652
query80	954	420	410	410
query81	458	238	231	231
query82	674	95	104	95
query83	181	136	135	135
query84	257	76	71	71
query85	894	321	323	321
query86	335	294	291	291
query87	3216	3043	3006	3006
query88	4072	2304	2300	2300
query89	446	323	289	289
query90	1927	201	218	201
query91	162	124	127	124
query92	63	54	52	52
query93	5947	612	568	568
query94	704	214	215	214
query95	1127	1085	1071	1071
query96	646	331	325	325
query97	6386	6416	6350	6350
query98	194	178	169	169
query99	3132	850	925	850
Total cold run time: 315293 ms
Total hot run time: 201768 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2024

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f14145f60396239ce6079d6a25fff66f87e8a425, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.02
query3	0.24	0.04	0.05
query4	1.82	0.07	0.07
query5	0.54	0.52	0.52
query6	1.22	0.65	0.62
query7	0.02	0.01	0.01
query8	0.03	0.02	0.03
query9	0.53	0.49	0.48
query10	0.53	0.53	0.53
query11	0.12	0.08	0.08
query12	0.12	0.09	0.09
query13	0.62	0.61	0.61
query14	0.78	0.78	0.78
query15	0.78	0.76	0.78
query16	0.40	0.37	0.37
query17	1.02	1.02	0.96
query18	0.25	0.22	0.25
query19	1.93	1.86	1.87
query20	0.01	0.01	0.01
query21	15.47	0.57	0.57
query22	2.26	2.64	1.47
query23	16.88	1.04	0.96
query24	6.96	1.47	0.88
query25	0.39	0.13	0.05
query26	0.67	0.15	0.15
query27	0.04	0.03	0.04
query28	5.95	0.80	0.72
query29	12.59	2.35	2.30
query30	0.56	0.49	0.52
query31	2.81	0.38	0.38
query32	3.38	0.50	0.50
query33	3.09	3.10	3.08
query34	15.24	4.79	4.79
query35	4.85	4.88	4.84
query36	1.05	1.01	1.02
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.07	0.02	0.01
query42	0.02	0.01	0.01
query43	0.02	0.01	0.02
Total cold run time: 103.62 s
Total hot run time: 30.53 s

@doris-robot
Copy link

doris-robot commented Aug 14, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit f14145f60396239ce6079d6a25fff66f87e8a425 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

xy720
xy720 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit bb2ed10 into apache:branch-2.0 Aug 15, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@cambyzju @Baymine
[fix](protocol) CLIENT_MULTI_STATEMENTS not used actually (apache#39308…
5ded27d 
…) (apache#39371)

pick apache#39308 to branch-2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720 xy720 xy720 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cambyzju @doris-robot @xy720