Skip to content

Add Rowset Interface#399

Merged
chaoyli merged 7 commits into
apache:be_refactorfrom
kangpinghuang:be_refactor
Dec 7, 2018
Merged

Add Rowset Interface#399
chaoyli merged 7 commits into
apache:be_refactorfrom
kangpinghuang:be_refactor

Conversation

@kangpinghuang
Copy link
Copy Markdown
Contributor

  1. add Rowset/RowsetWriter/RowsetReader interface
  2. add RowsetMeta

Comment thread be/src/rowset/rowset.h Outdated
Comment thread be/src/rowset/rowset_meta.h Outdated
Comment thread gensrc/proto/olap_file.proto Outdated
Comment thread be/src/rowset/rowset_writer.h Outdated
@@ -58,6 +58,39 @@ message PDelta {
optional DeleteConditionMessage delete_condition = 6;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think delete_predicate may be a better name.

Comment thread be/src/rowset/rowset_reader.h Outdated
Comment thread be/src/rowset/rowset_reader.h Outdated
Comment thread gensrc/proto/olap_file.proto
Comment thread be/src/olap/rowset_reader.h Outdated
// under the License.

#ifndef DORIS_BE_SRC_ROWSET_ROWSET_READER_H
#define DORIS_BE_SRC_ROWSET_ROWSET_READER_H
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DORIS_BE_SRC_ROWSET_ROWSET_READER_H to DORIS_BE_SRC_OLAP_ROWSET_READER_H

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaoyli chaoyli merged commit 18bda8c into apache:be_refactor Dec 7, 2018
kangpinghuang added a commit to kangpinghuang/incubator-doris that referenced this pull request Mar 14, 2019
- Add Rowset Interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants