Skip to content

[fix](catalog) hide some properties in show create catalog stmt #39946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Aug 27, 2024
Merged

[fix](catalog) hide some properties in show create catalog stmt #39946

morningman merged 1 commit into from
Aug 27, 2024

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Aug 26, 2024 •
edited
Loading

the use_meta_cache and create_time property should not be visible in
show create catalog stmt.
These properties are not for user.
But you can still see them in show catalog xxx stmt

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

morningman commented Aug 26, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

TPC-H: Total hot run time: 37685 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bbb59063865435c8de0a734c19d4e5041fc00d98, data reload: false

------ Round 1 ----------------------------------
q1	17617	4387	4328	4328
q2	2025	182	175	175
q3	11675	921	1166	921
q4	10492	722	738	722
q5	7764	2825	2795	2795
q6	228	138	138	138
q7	959	622	600	600
q8	9345	2096	2089	2089
q9	7153	6505	6503	6503
q10	6995	2207	2201	2201
q11	457	245	243	243
q12	391	222	225	222
q13	17771	3008	3029	3008
q14	295	240	237	237
q15	531	482	503	482
q16	496	404	388	388
q17	994	694	704	694
q18	7399	6789	6960	6789
q19	1376	1022	941	941
q20	673	320	327	320
q21	3909	2895	3047	2895
q22	1128	1024	994	994
Total cold run time: 109673 ms
Total hot run time: 37685 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4389	4261	4282	4261
q2	374	273	272	272
q3	2892	2706	2685	2685
q4	1954	1631	1616	1616
q5	5552	5685	5715	5685
q6	226	144	151	144
q7	2299	1857	1847	1847
q8	3306	3438	3456	3438
q9	8828	8888	8821	8821
q10	3571	3400	3362	3362
q11	623	529	561	529
q12	825	656	660	656
q13	16354	3216	3290	3216
q14	334	289	297	289
q15	547	498	495	495
q16	519	448	444	444
q17	1878	1541	1518	1518
q18	8089	7765	7861	7765
q19	1782	1635	1540	1540
q20	2161	1919	1889	1889
q21	5733	5602	5552	5552
q22	1101	1014	1026	1014
Total cold run time: 73337 ms
Total hot run time: 57038 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

TPC-DS: Total hot run time: 190422 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bbb59063865435c8de0a734c19d4e5041fc00d98, data reload: false

query1	1240	912	854	854
query2	6336	1910	1856	1856
query3	10598	3992	3897	3897
query4	59308	24470	23126	23126
query5	5394	486	490	486
query6	429	151	174	151
query7	5775	284	288	284
query8	289	204	201	201
query9	8900	2434	2447	2434
query10	476	261	257	257
query11	17062	15049	15224	15049
query12	162	109	103	103
query13	1601	376	371	371
query14	10947	7061	6618	6618
query15	224	174	187	174
query16	7450	470	467	467
query17	1143	582	598	582
query18	1811	304	304	304
query19	280	153	152	152
query20	119	110	117	110
query21	209	132	106	106
query22	4587	4448	4433	4433
query23	34532	33677	33413	33413
query24	5894	2883	2794	2794
query25	517	387	369	369
query26	676	154	149	149
query27	1775	270	274	270
query28	3590	2002	2001	2001
query29	643	391	395	391
query30	240	151	142	142
query31	923	777	747	747
query32	79	53	56	53
query33	444	279	276	276
query34	886	459	462	459
query35	825	710	694	694
query36	1073	917	923	917
query37	136	85	82	82
query38	4014	3792	3803	3792
query39	1477	1416	1385	1385
query40	203	116	114	114
query41	45	46	44	44
query42	118	98	93	93
query43	503	463	460	460
query44	1063	733	751	733
query45	197	164	170	164
query46	1066	733	719	719
query47	1881	1806	1814	1806
query48	360	282	277	277
query49	744	414	435	414
query50	801	412	401	401
query51	7239	7104	7051	7051
query52	95	83	85	83
query53	250	175	172	172
query54	558	447	442	442
query55	74	75	74	74
query56	275	249	255	249
query57	1181	1131	1063	1063
query58	216	225	230	225
query59	2954	2742	2739	2739
query60	289	262	271	262
query61	103	99	99	99
query62	716	666	638	638
query63	209	180	178	178
query64	2941	1740	1739	1739
query65	3262	3157	3154	3154
query66	609	337	327	327
query67	15369	15451	15283	15283
query68	3002	560	554	554
query69	395	277	279	277
query70	1174	1049	1129	1049
query71	331	282	273	273
query72	2604	2135	2080	2080
query73	704	319	321	319
query74	9228	8942	8705	8705
query75	3353	2730	2686	2686
query76	1410	971	999	971
query77	538	326	335	326
query78	10030	9068	9191	9068
query79	1021	550	520	520
query80	685	527	533	527
query81	457	229	229	229
query82	293	138	137	137
query83	181	158	160	158
query84	265	82	83	82
query85	740	283	287	283
query86	293	275	294	275
query87	4311	4257	4406	4257
query88	2865	2273	2272	2272
query89	376	281	280	280
query90	1880	192	188	188
query91	124	98	97	97
query92	61	52	55	52
query93	1048	519	527	519
query94	588	274	304	274
query95	319	258	257	257
query96	582	263	267	263
query97	3166	3069	3044	3044
query98	215	220	197	197
query99	1598	1298	1251	1251
Total cold run time: 299222 ms
Total hot run time: 190422 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

ClickBench: Total hot run time: 30.7 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bbb59063865435c8de0a734c19d4e5041fc00d98, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.03	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.07
query5	0.50	0.50	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.57	0.49	0.49
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.59	0.59
query14	0.77	0.80	0.81
query15	0.84	0.83	0.80
query16	0.37	0.38	0.38
query17	1.02	1.06	1.02
query18	0.21	0.20	0.20
query19	1.94	1.75	1.78
query20	0.01	0.01	0.01
query21	15.39	0.68	0.66
query22	4.02	7.61	1.80
query23	18.34	1.39	1.34
query24	2.10	0.24	0.21
query25	0.15	0.08	0.08
query26	0.26	0.19	0.17
query27	0.08	0.08	0.06
query28	13.22	1.01	0.99
query29	12.62	3.32	3.29
query30	0.25	0.06	0.06
query31	2.86	0.41	0.39
query32	3.26	0.48	0.48
query33	2.94	2.97	2.98
query34	17.08	4.39	4.40
query35	4.45	4.46	4.43
query36	0.67	0.48	0.52
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.06	0.06
query43	0.04	0.04	0.04
Total cold run time: 109.34 s
Total hot run time: 30.7 s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024

PR approved by anyone and no changes requested.

kaka11chen
kaka11chen approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 0202e7d into apache:master Aug 27, 2024
morningman added a commit to morningman/doris that referenced this pull request Aug 27, 2024
@morningman
[fix](catalog) hide some properties in show create catalog stmt (apac…
edbc08b 
…he#39946)

the `use_meta_cache` and `create_time` property should not be visible in
show create catalog stmt.
These properties are not for user.
But you can still see them in `show catalog xxx` stmt
@morningman morningman mentioned this pull request Aug 27, 2024
Merged
morningman added a commit that referenced this pull request Aug 27, 2024
@morningman
[fix](catalog) hide some properties in show create catalog stmt (#39946…
bbf7701 
…) (#39970)

bp #39946
morningman added a commit to morningman/doris that referenced this pull request Sep 3, 2024
@morningman
[fix](catalog) hide some properties in show create catalog stmt (apac…
07f5a09 
…he#39946)

the `use_meta_cache` and `create_time` property should not be visible in
show create catalog stmt.
These properties are not for user.
But you can still see them in `show catalog xxx` stmt
@morningman morningman mentioned this pull request Sep 3, 2024
Merged
morningman added a commit that referenced this pull request Sep 4, 2024
@morningman
[fix](catalog) hide some properties in show create catalog stmt (#39946…
dd9f1ec 
…) (#40329)

bp #39946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morningman @doris-robot @kaka11chen @wuwenchi @dataroaring