[fix](array/map) Fix semi-structure data column#40363
Closed
Gabriel39 wants to merge 1 commit intoapache:masterfrom
Closed
[fix](array/map) Fix semi-structure data column#40363Gabriel39 wants to merge 1 commit intoapache:masterfrom
Gabriel39 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
please add cases! |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38215 ms |
TPC-DS: Total hot run time: 192406 ms |
ClickBench: Total hot run time: 32.3 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Function
convert_to_full_column_if_constwill return a shared pointer with the origin column and add 1 touse countof this column if it is not a Array/Map column.For Array/Map columns,
convert_to_full_column_if_constwill return a new pointer which shares the internal nested columns with the origin columns.During execution, a column which is exclusive means it is not shared by another pointer so we can use this column as we want otherwise we should copy the data into another exclusive column.
Because
convert_to_full_column_if_constwill return a new pointer for Array/Map columns, we can not justuse count == 1to decide if the column is exclusive.