Skip to content

[fix](scanner-builder) Fix scan builder datarace beacause of picked from master's different codebase#41019

Merged
dataroaring merged 1 commit intoapache:branch-2.1from
Hastyshell:fix-pick-scan-builder-datarace
Sep 20, 2024
Merged

[fix](scanner-builder) Fix scan builder datarace beacause of picked from master's different codebase#41019
dataroaring merged 1 commit intoapache:branch-2.1from
Hastyshell:fix-pick-scan-builder-datarace

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Sep 19, 2024

Proposed changes

As title. Master will hold header lock internally when capturing read resource.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Hastyshell
Copy link
Collaborator Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 19, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9328/25800)
Line Coverage: 27.72% (76640/276468)
Region Coverage: 26.50% (39352/148505)
Branch Coverage: 23.30% (20041/86016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9daa9bc638ed72287053a4d386cfaf5efcd07519_9daa9bc638ed72287053a4d386cfaf5efcd07519/report/index.html

@dataroaring dataroaring merged commit a8aebe6 into apache:branch-2.1 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants