[fix](Nereids) merge request properties map of group should compare cost (#40819)#41615
Merged
morrySnow merged 1 commit intoapache:branch-2.1from Oct 10, 2024
Merged
[fix](Nereids) merge request properties map of group should compare cost (#40819)#41615morrySnow merged 1 commit intoapache:branch-2.1from
morrySnow merged 1 commit intoapache:branch-2.1from
Conversation
…ost (apache#40819) pick from master apache#40819 when do merge, we should update target requestPropertiesMap ONLY IF the cost of source's request property lower than target one. Otherwise, the requestPropertiesMap will not sync with lowestCostTable. Then, we will get wrong output property when get the final plan.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from master #40819
when do merge, we should update target requestPropertiesMap ONLY IF the cost of source's request property lower than target one. Otherwise, the requestPropertiesMap will not sync with lowestCostTable. Then, we will get wrong output property when get the final plan.