You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What types of changes does your code introduce to Doris? Put an x in the boxes that apply
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have create an issue on Doris's issues, and have described the bug/feature there in detail
Commit messages in my PR start with the related issues ID
Compiling and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
If this change need a document change, I have updated the document
@yangzhg@morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under fe/fe-core/src/main/cup/ directory？ which is friendly for new contributor.
@yangzhg@morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under fe/fe-core/src/main/cup/ directory？ which is friendly for new contributor.
@kangkaisen It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
@yangzhg@morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under fe/fe-core/src/main/cup/ directory？ which is friendly for new contributor.
@kangkaisen It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by one committer.area/sqlIssues or PRs related to SQL
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the Shift/Reduce conflict in cup file #4176
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.