Skip to content

[fix](http) Remove file if downloading faile is failed#41778

Merged
dataroaring merged 1 commit into
apache:masterfrom
w41ter:remove_files_when_http_download_failed
Oct 14, 2024
Merged

[fix](http) Remove file if downloading faile is failed#41778
dataroaring merged 1 commit into
apache:masterfrom
w41ter:remove_files_when_http_download_failed

Conversation

@w41ter
Copy link
Copy Markdown
Contributor

@w41ter w41ter commented Oct 14, 2024

No description provided.

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Copy Markdown
Contributor Author

w41ter commented Oct 14, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.48% (9705/25897)
Line Coverage: 28.74% (80526/280234)
Region Coverage: 28.19% (41684/147866)
Branch Coverage: 24.76% (21185/85560)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e68bd3d3a74a87929f422fa7ecaf702f3bbecd2_3e68bd3d3a74a87929f422fa7ecaf702f3bbecd2/report/index.html

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit da9acd0 into apache:master Oct 14, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Oct 15, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Oct 15, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Oct 15, 2024
w41ter added a commit that referenced this pull request Oct 15, 2024
w41ter added a commit that referenced this pull request Oct 15, 2024
@w41ter w41ter added dev/2.1.7-merged dev/2.0.16-merged-deprecated 2.0.16 is NOT and will NOT be released and removed dev/2.0.x dev/2.1.x labels Oct 15, 2024
@w41ter w41ter deleted the remove_files_when_http_download_failed branch October 16, 2024 02:30
w41ter added a commit that referenced this pull request Oct 16, 2024
@w41ter w41ter removed the dev/3.0.x label Oct 16, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.16-merged-deprecated 2.0.16 is NOT and will NOT be released dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants