Skip to content

Conversation

@justfortaste
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

#16553 cooldown_ttl and cooldown_datetime cann't set at the same time. If cooldown_datetime is set, cooldown_ttl will be set to -1.
Tablet::_get_newest_cooldown_time will always get storage_policy->cooldown_datetime , then all new rowsets will be incorrectly cooldowned.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

if cooldown_ttl is -1, then cooldown_datetime is used, original code is right. Could you show an bad case?

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@justfortaste
Copy link
Contributor Author

if cooldown_ttl is -1, then cooldown_datetime is used, original code is right. Could you show an bad case?

CREATE STORAGE POLICY test_policy PROPERTIES( "storage_resource" = "xxxx", "cooldown_datetime" = "2020-10-18 12:00:00" );

the new segments will cooldown, but their time is bigger than CooldownDatetime "2020-10-18 12:00:00".

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Apr 22, 2025
@github-actions github-actions bot closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants