-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](cooldown) fix cooldown datetime #42083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
if cooldown_ttl is -1, then cooldown_datetime is used, original code is right. Could you show an bad case? |
lide-reed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
CREATE STORAGE POLICY test_policy PROPERTIES( "storage_resource" = "xxxx", "cooldown_datetime" = "2020-10-18 12:00:00" ); the new segments will cooldown, but their time is bigger than CooldownDatetime "2020-10-18 12:00:00". |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
We're closing this PR because it hasn't been updated in a while. |
Proposed changes
Issue Number: close #xxx
#16553 cooldown_ttl and cooldown_datetime cann't set at the same time. If cooldown_datetime is set, cooldown_ttl will be set to -1.
Tablet::_get_newest_cooldown_time will always get storage_policy->cooldown_datetime , then all new rowsets will be incorrectly cooldowned.