Skip to content

Comments

[fix](result sink) fix error 'Message size exceeds 2GB' with big result row#42304

Closed
jacktengg wants to merge 1 commit intoapache:masterfrom
jacktengg:fix-1023
Closed

[fix](result sink) fix error 'Message size exceeds 2GB' with big result row#42304
jacktengg wants to merge 1 commit intoapache:masterfrom
jacktengg:fix-1023

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Oct 23, 2024

Proposed changes

Issue Number: close #xxx

With big memory result row, it's easy to reach proto buffer message size limit and result in query error of Message size exceeds 2GB, and currently the row count of result block is fixed to 4096 * 8.

This PR add a session variable result_batch_rows to make it configurable.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 23, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9707/25911)
Line Coverage: 28.71% (80479/280280)
Region Coverage: 28.15% (41627/147896)
Branch Coverage: 24.70% (21138/85576)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae411eaed9ae37aa0f7de2ba4917e5ae955ae244_ae411eaed9ae37aa0f7de2ba4917e5ae955ae244/report/index.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@jacktengg
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9707/25903)
Line Coverage: 28.74% (80516/280188)
Region Coverage: 28.16% (41627/147833)
Branch Coverage: 24.72% (21151/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2b2601442857855b3c056ef2df4da4085aabcb86_2b2601442857855b3c056ef2df4da4085aabcb86/report/index.html

@jacktengg
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.48% (9712/25914)
Line Coverage: 28.75% (80577/280247)
Region Coverage: 28.17% (41648/147838)
Branch Coverage: 24.74% (21161/85538)
Coverage Report: http://coverage.selectdb-in.cc/coverage/373e805f350186e89a23b2a1212f3706214f6408_373e805f350186e89a23b2a1212f3706214f6408/report/index.html

@jacktengg jacktengg force-pushed the fix-1023 branch 2 times, most recently from d62ddb9 to acd7f28 Compare October 24, 2024 16:17
@jacktengg
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9713/25924)
Line Coverage: 28.75% (80583/280337)
Region Coverage: 28.16% (41643/147891)
Branch Coverage: 24.73% (21159/85564)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b5700f0ea69fd8091184a93758f2cae15900830d_b5700f0ea69fd8091184a93758f2cae15900830d/report/index.html

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Apr 23, 2025
@github-actions github-actions bot closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants