[test](p0) fix load stream leak in injection cases#42681
Merged
liaoxin01 merged 1 commit intoapache:masterfrom Oct 30, 2024
Merged
[test](p0) fix load stream leak in injection cases#42681liaoxin01 merged 1 commit intoapache:masterfrom
liaoxin01 merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
liaoxin01
approved these changes
Oct 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
## Proposed changes Some injection cases (e.g. `VTabletWriterV2._open_streams_to_backend.node_info_null`) will cause LoadStream leak. Because the injection was disabled too early. When some sink operators returns "failed" status to the user (regression framework), other sinks are still executing. Causing partially opened LoadStreams (some instances are not fault-injected, and successfully open the stream). We should wait a small amount of time to safely assume all instances are done, before disabling the injection.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Nov 4, 2024
## Proposed changes Some injection cases (e.g. `VTabletWriterV2._open_streams_to_backend.node_info_null`) will cause LoadStream leak. Because the injection was disabled too early. When some sink operators returns "failed" status to the user (regression framework), other sinks are still executing. Causing partially opened LoadStreams (some instances are not fault-injected, and successfully open the stream). We should wait a small amount of time to safely assume all instances are done, before disabling the injection.
dataroaring
pushed a commit
that referenced
this pull request
Nov 4, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Nov 8, 2024
## Proposed changes Some injection cases (e.g. `VTabletWriterV2._open_streams_to_backend.node_info_null`) will cause LoadStream leak. Because the injection was disabled too early. When some sink operators returns "failed" status to the user (regression framework), other sinks are still executing. Causing partially opened LoadStreams (some instances are not fault-injected, and successfully open the stream). We should wait a small amount of time to safely assume all instances are done, before disabling the injection.
dataroaring
pushed a commit
that referenced
this pull request
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some injection cases (e.g.
VTabletWriterV2._open_streams_to_backend.node_info_null) will cause LoadStream leak.Because the injection was disabled too early.
When some sink operators returns "failed" status to the user (regression framework), other sinks are still executing.
Causing partially opened LoadStreams (some instances are not fault-injected, and successfully open the stream).
We should wait a small amount of time to safely assume all instances are done, before disabling the injection.