Skip to content

[fix](regression-test) fix test_hive_serde_prop #42886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Nov 1, 2024
Merged

[fix](regression-test) fix test_hive_serde_prop #42886

morningman merged 2 commits into from
Nov 1, 2024

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Oct 30, 2024

Proposed changes

fellow #42200

Null values ​​in text tables are now correctly recognized now.

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Oct 30, 2024

run buildall

@suxiaogang223 suxiaogang223 marked this pull request as draft October 30, 2024 06:32
@suxiaogang223 suxiaogang223 marked this pull request as ready for review October 31, 2024 11:10
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Oct 31, 2024

run buildall

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Oct 31, 2024 •
edited
Loading

There are inconsistencies between hive2 and hive3 regarding whether to print false values.

hive> select * from test_open_csv_default_prop;
OK
1       John Doe        28      50000.75        TRUE    2022-01-15      2023-10-21 14:30:00     4.5     Senior Developer
2       Jane,Smith                              2020-05-20                      "Project Manager"
Time taken: 0.053 seconds, Fetched: 2 row(s)
hive> select * from serde_test7;
OK
1       NULL
2       |||
3       aaa
4       "null"
Time taken: 0.05 seconds, Fetched: 4 row(s)

morningman
morningman approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit beef40f into apache:master Nov 1, 2024
morningman pushed a commit to morningman/doris that referenced this pull request Nov 1, 2024
@suxiaogang223 @morningman
[fix](regression-test) fix test_hive_serde_prop (apache#42886)
37782fe 
## Proposed changes
fellow apache#42200

Null values ​​in text tables are now correctly recognized now.
@morningman morningman mentioned this pull request Nov 1, 2024
Merged
morningman pushed a commit to morningman/doris that referenced this pull request Nov 1, 2024
@suxiaogang223 @morningman
[fix](regression-test) fix test_hive_serde_prop (apache#42886)
970fad8 
## Proposed changes
fellow apache#42200

Null values ​​in text tables are now correctly recognized now.
github-actions bot pushed a commit that referenced this pull request Nov 1, 2024
@suxiaogang223
[fix](regression-test) fix test_hive_serde_prop (#42886)
600666d 
## Proposed changes
fellow #42200

Null values ​​in text tables are now correctly recognized now.
@morningman morningman mentioned this pull request Nov 1, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
yiguolei pushed a commit that referenced this pull request Nov 1, 2024
@morningman @suxiaogang223
[fix](regression-test) fix test_hive_serde_prop #42886 (#43098)
98d3db0 
cherry pick from #42886

Co-authored-by: Socrates <suxiaogang223@icloud.com>
morningman added a commit that referenced this pull request Nov 1, 2024
@morningman @suxiaogang223
[fix](regression-test) fix test_hive_serde_prop #42886 (#43099)
757b0ea 
cherry pick from #42886

Co-authored-by: Socrates <suxiaogang223@icloud.com>
@suxiaogang223 suxiaogang223 deleted the fix_serde_prop_case branch November 5, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223 @doris-robot @morningman @wuwenchi @yiguolei