[improvement](nereids) Use a unified approach to deal with monotonic function in partition prune #42934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
morrySnow
previously approved these changes
Nov 7, 2024
...rc/main/java/org/apache/doris/nereids/rules/expression/rules/OneRangePartitionEvaluator.java
Show resolved
Hide resolved
feiniaofeiafei
force-pushed
the
partition_prune_add
branch
from
e7055c9 to
355a721
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
924060929
reviewed
Nov 26, 2024
Comment on lines
806
to
811
| if (partitionSlotContainsNull.containsKey(funcChild)) { | ||
| forNullable = func.withConstantArgs(partitionSlotContainsNull.get(funcChild) | ||
| ? new Nullable(funcChild) : new NonNullable(funcChild)); | ||
| } else { | ||
| forNullable = func.withConstantArgs(new Nullable(funcChild)); | ||
| } |
Contributor
There was a problem hiding this comment.
boolean isNullable = partitionSlotContainsNull.getOrDefault(funcChild, true);
Expression withNullable = func.withConstantArgs(
isNullable ? new Nullable(funcChild) : new NonNullable(funcChild)
);
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
morrySnow
approved these changes
Nov 27, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Nov 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
… in partition prune (#42934) This pr use a unified approach to deal with monotonic function in partition prune. When adding a monotonic function in partition prune, we don't need to add visitXXX in OneRangePartitionEvaluator, only need to implement the Monotonic interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pr use a unified approach to deal with monotonic function in partition prune. When adding a monotonic function in partition prune, we don't need to add visitXXX in OneRangePartitionEvaluator, only need to implement the Monotonic interface.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)