[Fix]Fix implicit type conversion for format_ip.h/hash_map_context.h/hash_…#43604
[Fix]Fix implicit type conversion for format_ip.h/hash_map_context.h/hash_…#43604wangbo wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
wangbo
force-pushed
the
1108_compile_check
branch
2 times, most recently
from
2efbe6d to
08a9c8a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| for (size_t offset = 0; offset < min_size; offset += 16) { | ||
| uint16_t mask = _mm_movemask_epi8( | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
| int memcmp_small_allow_overflow15(const Char* a, const Char* b, size_t size) { | ||
| for (size_t offset = 0; offset < size; offset += 16) { | ||
| uint16_t mask = _mm_movemask_epi8( | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
|
|
||
| for (size_t offset = 0; offset < a_size; offset += 16) { | ||
| uint16_t mask = _mm_movemask_epi8( | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
| int memcmp_small_multiple_of16(const Char* a, const Char* b, size_t size) { | ||
| for (size_t offset = 0; offset < size; offset += 16) { | ||
| uint16_t mask = _mm_movemask_epi8( | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
| uint16_t mask = | ||
| _mm_movemask_epi8(_mm_cmpeq_epi8(_mm_loadu_si128(reinterpret_cast<const __m128i*>(a)), | ||
| _mm_loadu_si128(reinterpret_cast<const __m128i*>(b)))); | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
|
|
||
| for (size_t offset = 0; offset < size; offset += 16) { | ||
| uint16_t mask = _mm_movemask_epi8( | ||
| uint16_t mask = (uint16_t)_mm_movemask_epi8( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| uint16_t mask = (uint16_t)_mm_movemask_epi8( | |
| auto mask = (uint16_t)_mm_movemask_epi8( |
…table.h/memcmp_small.h
wangbo
force-pushed
the
1108_compile_check
branch
from
08a9c8a to
eb5a052
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
| size_degree = num_elems <= 1 ? initial_size_degree | ||
| : (initial_size_degree > fill_capacity ? initial_size_degree | ||
| : fill_capacity); | ||
| size_degree = (doris::vectorized::UInt8)( |
There was a problem hiding this comment.
why change size_degree to uint32 or uint64?
There was a problem hiding this comment.
because size_degree = log2(xxx) when set_buf_size, so uint8 is enough.
|
We're closing this PR because it hasn't been updated in a while. |
3 participants
What problem does this PR solve?
Fix implicit type conversion for format_ip.h/hash_map_context.h/hash_table.h/memcmp_small.h
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)