[Refactor](inverted index) refactor inverted index file writer for v1/v2 index write #42328#43993
Merged
airborne12 merged 1 commit intoapache:branch-3.0from Nov 15, 2024
Conversation
…/v2 index write (apache#42328) The original write_v1 and write_v2 methods in the inverted index file writer were overly long and difficult to maintain. This PR refactors these methods to improve code maintainability and readability.
Member
Author
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+29
to
+30
| namespace doris { | ||
| namespace segment_v2 { |
Contributor
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Suggested change
| namespace doris { | |
| namespace segment_v2 { | |
| namespace doris::segment_v2 { |
be/test/olap/rowset/segment_v2/inverted_index_file_writer_test.cpp:513:
- } // namespace segment_v2
- } // namespace doris
+ } // namespace doris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick from #42328