Skip to content

[comment](sort) Add some comments for sort_column#44024

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:comment_1115
Nov 18, 2024
Merged

[comment](sort) Add some comments for sort_column#44024
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:comment_1115

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

@Gabriel39 Gabriel39 commented Nov 15, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.00% (9902/26057)
Line Coverage: 29.19% (82741/283496)
Region Coverage: 28.31% (42498/150093)
Branch Coverage: 24.89% (21547/86582)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ef080a7af6e00d12972ad4042f73cfa58f0bbd7e_ef080a7af6e00d12972ad4042f73cfa58f0bbd7e/report/index.html

Copy link
Copy Markdown
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Copy Markdown
Contributor

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.98% (9895/26053)
Line Coverage: 29.17% (82703/283511)
Region Coverage: 28.29% (42463/150097)
Branch Coverage: 24.87% (21536/86590)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d3dca600e0be7eab520ba7f75fa51e6842f80a24_d3dca600e0be7eab520ba7f75fa51e6842f80a24/report/index.html

@Gabriel39 Gabriel39 merged commit 9dd0c3d into apache:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants