Skip to content

[opt](log) Detail log for file cache resource limit mode #44094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Nov 26, 2024
Merged

[opt](log) Detail log for file cache resource limit mode #44094

dataroaring merged 2 commits into from
Nov 26, 2024

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Nov 17, 2024

What problem does this PR solve?

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

gavinchou commented Nov 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 17, 2024

TeamCity be ut coverage result:
Function Coverage: 37.97% (9901/26074)
Line Coverage: 29.17% (82747/283690)
Region Coverage: 28.31% (42501/150141)
Branch Coverage: 24.89% (21556/86612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3f5c34c6473a12af9e02652ddaf4c4b672781251_3f5c34c6473a12af9e02652ddaf4c4b672781251/report/index.html

freemandealer
freemandealer approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR approved by anyone and no changes requested.

@gavinchou gavinchou force-pushed the gavin-opt-file-cache-log branch from 3f5c34c to 5dd8506 Compare November 18, 2024 04:07
@gavinchou
Copy link
Contributor Author

gavinchou commented Nov 18, 2024

run buildalll

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Contributor Author

gavinchou commented Nov 20, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 20, 2024

TeamCity be ut coverage result:
Function Coverage: 38.02% (9900/26038)
Line Coverage: 29.20% (82790/283540)
Region Coverage: 28.33% (42509/150054)
Branch Coverage: 24.90% (21558/86582)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5dd8506e1b29eb405fdfe9c244f92362d18910d9_5dd8506e1b29eb405fdfe9c244f92362d18910d9/report/index.html

dataroaring
dataroaring approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@gavinchou
Copy link
Contributor Author

gavinchou commented Nov 21, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 21, 2024

TeamCity be ut coverage result:
Function Coverage: 38.03% (9900/26033)
Line Coverage: 29.20% (82798/283515)
Region Coverage: 28.34% (42532/150082)
Branch Coverage: 24.90% (21562/86590)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dd05edd64f4f3460bf1bf123042a32610bfa3bc8_dd05edd64f4f3460bf1bf123042a32610bfa3bc8/report/index.html

dataroaring
dataroaring approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 54f87af into apache:master Nov 26, 2024
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
@gavinchou
[opt](log) Detail log for file cache resource limit mode (#44094)
25c6167
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 29, 2024
@github-actions @gavinchou
branch-3.0: [opt](log) Detail log for file cache resource limit mode #…
c67a806 
…44094 (#44646)

Cherry-picked from #44094

Co-authored-by: Gavin Chou <gavin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+2 more reviewers

@freemandealer freemandealer freemandealer approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gavinchou @doris-robot @freemandealer @Yukang-Lian @dataroaring