Skip to content

[Enhancement](recyclebin) drop table keep temp partitions in recycle-bin#44097

Merged
dataroaring merged 1 commit intoapache:masterfrom
Vallishp:drop_table_keep_temp_partition_in_recycle
Nov 28, 2024
Merged

[Enhancement](recyclebin) drop table keep temp partitions in recycle-bin#44097
dataroaring merged 1 commit intoapache:masterfrom
Vallishp:drop_table_keep_temp_partition_in_recycle

Conversation

@Vallishp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #44096

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test //added
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
      Behaviour changed. older version doesnt keep the temp partitions in the recyclebin
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@deardeng
Copy link
Contributor

In what scenario, a temporary partition is dropped and needs to be recovered again?

@Vallishp
Copy link
Contributor Author

In what scenario, a temporary partition is dropped and needs to be recovered again?

Currently we dont have any specific scenario currently. but idea is user should have a chance to recover temp partition data, if accidentally drop the table. we will added same logic for truncate table case also.

@deardeng
Copy link
Contributor

In what scenario, a temporary partition is dropped and needs to be recovered again?

Currently we dont have any specific scenario currently. but idea is user should have a chance to recover temp partition data, if accidentally drop the table. we will added same logic for truncate table case also.

Due to previous code comments drop all temp partitions of this table, so that there is no temp partitions in recycle bin, , will this change introduce unknown issues? You can contact Mingyu Chen to confirm

@Vallishp
Copy link
Contributor Author

@morningman PTAL

Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring changed the title [Enhancement] drop table keep temp partitions in recycle-bin [Enhancement](recyclebin) drop table keep temp partitions in recycle-bin Nov 28, 2024
@dataroaring dataroaring merged commit 96079bc into apache:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/behavior-changed reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Drop table should keep temp partitions also in recycle-bin

5 participants