Skip to content

[improve](cloud-mow) Optimize log output when missing delete bitmap cache#44446

Merged
dataroaring merged 1 commit intoapache:masterfrom
hust-hhb:miss-log
Nov 25, 2024
Merged

[improve](cloud-mow) Optimize log output when missing delete bitmap cache#44446
dataroaring merged 1 commit intoapache:masterfrom
hust-hhb:miss-log

Conversation

@hust-hhb
Copy link
Contributor

What problem does this PR solve?

Problem Summary: When there is new rowset genarate, query node will not find the delete bitmap of this new rowset in cache, because cache only exists on the write node, so need to sync delete bitmap from ms, this pr reduce the reduce the unnecessary log output about not found cache.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.31% (9979/26045)
Line Coverage: 29.42% (83474/283756)
Region Coverage: 28.56% (42932/150301)
Branch Coverage: 25.15% (21813/86716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8a8793127b5d28701ab7d8e22d091573d9336dd6_8a8793127b5d28701ab7d8e22d091573d9336dd6/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7498239 into apache:master Nov 25, 2024
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
…ache (#44446)

Problem Summary: When there is new rowset genarate, query node will not
find the delete bitmap of this new rowset in cache, because cache only
exists on the write node, so need to sync delete bitmap from ms, this pr
reduce the reduce the unnecessary log output about not found cache.
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
…ete bitmap cache #44446 (#44559)

Cherry-picked from #44446

Co-authored-by: huanghaibin <huanghaibin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments