Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

Cherry-picked from #44692

…pe (#44692)

Problem Summary:

Some user can create Duplicate keys table with
`enable_unique_key_merge_on_write=true` in version 1.2, when they
upgrade to version 2.0, some logic in BE treat such table as an unique
key mow table, make a wrong query plan, which cause BE core.

In the method `OlapTable::getEnableUniqueKeyMergeOnWrite()`, we should
check if the table is a unique key table.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 3, 2024
@dataroaring dataroaring reopened this Dec 3, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40362 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd3c819d17b867e2858db64bd85cebc8d9d91901, data reload: false

------ Round 1 ----------------------------------
q1	17583	7425	7335	7335
q2	2056	168	170	168
q3	10713	1137	1122	1122
q4	10559	776	701	701
q5	7738	2774	2773	2773
q6	236	150	149	149
q7	963	608	597	597
q8	9586	1863	2006	1863
q9	8069	6388	6438	6388
q10	7002	2286	2326	2286
q11	452	270	259	259
q12	406	215	203	203
q13	17759	2962	2966	2962
q14	231	211	207	207
q15	562	526	518	518
q16	683	606	612	606
q17	953	603	576	576
q18	7082	6489	6535	6489
q19	3446	1036	923	923
q20	470	205	192	192
q21	3874	3278	3100	3100
q22	1087	947	945	945
Total cold run time: 111510 ms
Total hot run time: 40362 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7406	7280	7234	7234
q2	328	231	227	227
q3	3014	2888	2899	2888
q4	2133	1759	1766	1759
q5	5614	5714	5723	5714
q6	224	139	144	139
q7	2218	1772	1738	1738
q8	3387	3447	3390	3390
q9	8894	8868	8848	8848
q10	3549	3458	3502	3458
q11	592	504	508	504
q12	851	567	568	567
q13	16501	3107	3129	3107
q14	300	271	270	270
q15	592	506	516	506
q16	695	674	666	666
q17	1819	1597	1610	1597
q18	8288	7806	7427	7427
q19	1715	1516	1667	1516
q20	2069	1814	1876	1814
q21	5330	5171	5256	5171
q22	1071	1006	1017	1006
Total cold run time: 76590 ms
Total hot run time: 59546 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194695 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd3c819d17b867e2858db64bd85cebc8d9d91901, data reload: false

query1	1244	944	905	905
query2	6253	2088	2057	2057
query3	10836	3910	4081	3910
query4	66405	29142	23479	23479
query5	5377	470	429	429
query6	440	175	165	165
query7	5656	337	313	313
query8	316	236	229	229
query9	9185	2684	2632	2632
query10	529	267	251	251
query11	18120	15149	15830	15149
query12	161	103	100	100
query13	1542	433	431	431
query14	10862	6433	7448	6433
query15	218	175	183	175
query16	7295	476	485	476
query17	1299	593	576	576
query18	1910	355	320	320
query19	239	158	154	154
query20	118	114	121	114
query21	212	108	101	101
query22	4867	4502	4472	4472
query23	34418	34209	34042	34042
query24	6213	2940	2910	2910
query25	560	420	439	420
query26	716	177	167	167
query27	2026	310	304	304
query28	4165	2565	2545	2545
query29	711	490	446	446
query30	245	164	165	164
query31	994	823	839	823
query32	63	50	56	50
query33	461	270	275	270
query34	899	498	518	498
query35	890	714	716	714
query36	1074	937	946	937
query37	116	72	70	70
query38	4059	3942	4006	3942
query39	1542	1469	1476	1469
query40	201	96	97	96
query41	48	46	44	44
query42	106	95	96	95
query43	528	492	515	492
query44	1162	799	810	799
query45	184	165	161	161
query46	1138	700	755	700
query47	1998	1881	1907	1881
query48	467	381	365	365
query49	710	396	381	381
query50	817	417	423	417
query51	7395	7197	7058	7058
query52	96	89	87	87
query53	262	187	177	177
query54	553	439	436	436
query55	72	74	73	73
query56	255	226	224	224
query57	1167	1120	1089	1089
query58	202	199	194	194
query59	3243	2869	2944	2869
query60	264	245	240	240
query61	136	104	107	104
query62	793	636	652	636
query63	203	186	189	186
query64	1786	649	608	608
query65	3216	3173	3162	3162
query66	713	297	293	293
query67	15876	15358	15402	15358
query68	4626	570	563	563
query69	426	254	252	252
query70	1130	1120	1127	1120
query71	421	247	248	247
query72	6583	3933	3767	3767
query73	759	343	339	339
query74	10161	8865	8947	8865
query75	3385	2619	2623	2619
query76	2837	1017	1001	1001
query77	524	270	259	259
query78	10787	9688	9389	9389
query79	10268	589	609	589
query80	1704	419	407	407
query81	541	241	232	232
query82	1341	112	110	110
query83	291	144	145	144
query84	295	80	83	80
query85	1604	300	291	291
query86	453	299	301	299
query87	4458	4264	4281	4264
query88	5444	2397	2406	2397
query89	536	286	293	286
query90	2112	185	180	180
query91	181	144	165	144
query92	61	49	49	49
query93	6553	546	541	541
query94	893	282	267	267
query95	351	252	244	244
query96	628	280	276	276
query97	3367	3131	3108	3108
query98	228	200	208	200
query99	1727	1306	1299	1299
Total cold run time: 340502 ms
Total hot run time: 194695 ms

@zhannngchen zhannngchen merged commit 5149adb into branch-3.0 Dec 3, 2024
19 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-44692-branch-3.0 branch December 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants