Skip to content

branch-2.1: [fix](unique key) getEnableUniqueKeyMergeOnWrite should check keys type #44692 #44896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Dec 3, 2024
Merged

branch-2.1: [fix](unique key) getEnableUniqueKeyMergeOnWrite should check keys type #44692 #44896

zhannngchen merged 1 commit into from
Dec 3, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

Cherry-picked from #44692

[fix](unique key) getEnableUniqueKeyMergeOnWrite should check keys ty…
17b70f3 
…pe (#44692)

Problem Summary:

Some user can create Duplicate keys table with
`enable_unique_key_merge_on_write=true` in version 1.2, when they
upgrade to version 2.0, some logic in BE treat such table as an unique
key mow table, make a wrong query plan, which cause BE core.

In the method `OlapTable::getEnableUniqueKeyMergeOnWrite()`, we should
check if the table is a unique key table.
@doris-robot
Copy link

doris-robot commented Dec 3, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 3, 2024
@dataroaring dataroaring reopened this Dec 3, 2024
@doris-robot
Copy link

doris-robot commented Dec 3, 2024

run buildall

@zhannngchen zhannngchen merged commit e10f1e9 into branch-2.1 Dec 3, 2024
18 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-44692-branch-2.1 branch December 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@doris-robot @zhannngchen @dataroaring